ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-479

QuorumHierarchical does not count groups correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: quorum
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.

      1. ZOOKEEPER-479-branch3.2.patch
        6 kB
        Flavio Junqueira
      2. ZOOKEEPER-479.patch
        2 kB
        Flavio Junqueira
      3. ZOOKEEPER-479.patch
        5 kB
        Flavio Junqueira
      4. ZOOKEEPER-479.patch
        6 kB
        Flavio Junqueira

        Issue Links

          Activity

          Hide
          Flavio Junqueira added a comment -

          This patch fixes this issue and adds one more test.

          Show
          Flavio Junqueira added a comment - This patch fixes this issue and adds one more test.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12414004/ZOOKEEPER-479.patch
          against trunk revision 798038.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414004/ZOOKEEPER-479.patch against trunk revision 798038. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          This patch will probably keep failing until we have ZOOKEEPER-481 in. Also, I'm adding support to get the weight of servers to QuorumVerifiers, which we'll need in ZOOKEEPER-491.

          Show
          Flavio Junqueira added a comment - This patch will probably keep failing until we have ZOOKEEPER-481 in. Also, I'm adding support to get the weight of servers to QuorumVerifiers, which we'll need in ZOOKEEPER-491 .
          Hide
          Benjamin Reed added a comment -

          +1 looks good.

          Show
          Benjamin Reed added a comment - +1 looks good.
          Hide
          Flavio Junqueira added a comment -

          Made a small modification to the test in the patch, and uploading a 3.2 version.

          Show
          Flavio Junqueira added a comment - Made a small modification to the test in the patch, and uploading a 3.2 version.
          Hide
          Mahadev konar added a comment -

          I just committed this. thanks flavio !!

          Show
          Mahadev konar added a comment - I just committed this. thanks flavio !!
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #404 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/404/)
          . QuorumHierarchical does not count groups correctly (flavio via mahadev)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #404 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/404/ ) . QuorumHierarchical does not count groups correctly (flavio via mahadev)

            People

            • Assignee:
              Flavio Junqueira
              Reporter:
              Flavio Junqueira
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development