[ZOOKEEPER-4713] ObserverZooKeeperServer.shutdown() is redundant

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 3.5.10, 3.6.3, 3.7.0, 3.8.0, 3.7.1, 3.6.4, 3.8.1
• Component/s: quorum, server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Sirius
• Created: 29/Jun/23 11:20
• Updated: 21/Sep/24 02:19
• Resolved: 21/Sep/24 02:17

Description

After the FIX of ZOOKEEPER-1796, LearnerZooKeeperServer.shutdown() should be responsible for the shutdown logic of both the follower and observer. ObserverZooKeeperServer.shutdown() seems redundant, because it is not in the call stack of Observer.shutdown(). (Note that FollowerZooKeeperServer does not have the shutdown() method.)

Related analysis can be found in ZOOKEEPER-4712

Issue Links

• is superceded by: ZOOKEEPER-4712 Follower.shutdown() and Observer.shutdown() do not correctly shutdown the syncProcessor, which may lead to data inconsistency
• links to: GitHub Pull Request #2029