[ZOOKEEPER-4604] Creating a COMPLETION_STRING_STAT would set acl_result completion

• Type: Bug
• Status: Patch Available
• Priority: Trivial
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Adam Yi
• Created: 01/Aug/22 05:30
• Updated: 01/Aug/22 05:43

Description

    case COMPLETION_STRING_STAT:
        c->c.string_stat_result = (string_stat_completion_t)dc;
    case COMPLETION_ACLLIST:
        c->c.acl_result = (acl_completion_t)dc;
        break;

`c->c` is a union so setting c.acl_result would override c.string_stat_result. However, since they're all function pointers pointing to the same function, this won't cause any issue as c.string_stat_result is still correct. This might cause issue if we change the type of these completions in the future.

Issue Links

• links to: GitHub Pull Request #1912