ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-457

Make ZookeeperMain public, support for HBase (and other) embedded clients

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hi folks, we have made some changes to zookeeper to facilitate providing an embedded zk client in our own hbase client. This will allow our users to use 1 shell to manipulate both hbase things and zookeeper things. It requires making a few things public, and in the process rearranging how some static things are initialized.

      It's fairly trivial refactoring, hopefully you guys approve!

      Thanks!

      1. zk.patch
        5 kB
        ryan rawson

        Activity

        Hide
        Patrick Hunt added a comment -

        The 3.2.0 release candidate has already been cut, please see/discuss on the zookeeper-dev list thread.

        Is this something critical for 3.2.0 or can it wait for 3.2.1/3.3.0? (again, please discuss on the list thread)

        Show
        Patrick Hunt added a comment - The 3.2.0 release candidate has already been cut, please see/discuss on the zookeeper-dev list thread. Is this something critical for 3.2.0 or can it wait for 3.2.1/3.3.0? (again, please discuss on the list thread)
        Hide
        ryan rawson added a comment -

        it doesn't matter, i just tried to pick something that seemed ok, but obviously it didnt work.

        we can push it back.

        Show
        ryan rawson added a comment - it doesn't matter, i just tried to pick something that seemed ok, but obviously it didnt work. we can push it back.
        Hide
        Nitay Joffe added a comment -

        For reference, this is currently in HBase's ZooKeeper jar. The relevant HBase issue is: HBASE-1329.

        Show
        Nitay Joffe added a comment - For reference, this is currently in HBase's ZooKeeper jar. The relevant HBase issue is: HBASE-1329 .
        Hide
        Patrick Hunt added a comment -

        Marking for 3.3, we may also want to consider for 3.2.1 (this is not strictly a bug however)

        Show
        Patrick Hunt added a comment - Marking for 3.3, we may also want to consider for 3.2.1 (this is not strictly a bug however)
        Hide
        Patrick Hunt added a comment -

        Looks good, +1. Thanks Ryan!

        Committed revision 799741.
        Committed revision 799742.

        Show
        Patrick Hunt added a comment - Looks good, +1. Thanks Ryan! Committed revision 799741. Committed revision 799742.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #401 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/401/)
        . Make ZookeeperMain public, support for HBase (and other) embedded clients

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #401 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/401/ ) . Make ZookeeperMain public, support for HBase (and other) embedded clients

          People

          • Assignee:
            ryan rawson
            Reporter:
            ryan rawson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development