[ZOOKEEPER-4551] Do not log spammy stacktrace when a client closes its connection

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.4, 3.9.0, 3.8.1, 3.7.2
• Component/s: server
• Labels: pull-request-available
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 31/May/22 11:44
• Updated: 30/Jan/23 07:57
• Resolved: 01/Jun/22 15:36

Description

Currently (3.8, but this has always been happening IIRC), the server logs a scary stacktrace when a client closes its connection.

This is not something the administrator should be afraid of, so we should not write the stacktrace on the logs.

 

 
2022-05-31T08:55:22,205+0000 [NIOWorkerThread-1] WARN  org.apache.zookeeper.server.NIOServerCnxn - Unexpected exception                                                                                          │
│ org.apache.zookeeper.server.ServerCnxn$EndOfStreamException: Unable to read additional data from client, it probably closed the socket: address = /10.44.1.5:43468, session = 0x100002ec7a30032                  │
│     at org.apache.zookeeper.server.NIOServerCnxn.handleFailedRead(NIOServerCnxn.java:170) ~[org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]                                                                      │
│     at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:333) [org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]                                                                                   │
│     at org.apache.zookeeper.server.NIOServerCnxnFactory$IOWorkRequest.doWork(NIOServerCnxnFactory.java:508) [org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]                                                     │
│     at org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:153) [org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]            

                                                  │
│     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]                                                                                                                     │
│     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]                                                                                                                     │
│     at java.lang.Thread.run(Thread.java:829) [?:?]    

Issue Links

• links to: GitHub Pull Request #1889