[ZOOKEEPER-4380] Avoid NPE in RateLogger#rateLimitLog

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.8.0, 3.7.1
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Wenjun Ruan
• Created: 19/Sep/21 13:54
• Updated: 23/Sep/21 01:45
• Resolved: 22/Sep/21 15:23

Description

The newMsg may cause NPE

/**
 * In addition to the message, it also takes a value.
 */
public void rateLimitLog(String newMsg, String value) {
    long now = Time.currentElapsedTime();
    if (newMsg.equals(msg)) {
        ++count;
        this.value = value;
        if (now - timestamp >= LOG_INTERVAL) {
            flush();
            msg = newMsg;
            timestamp = now;
            this.value = value;
        }
    } else {
        flush();
        msg = newMsg;
        this.value = value;
        timestamp = now;
        LOG.warn("Message:{} Value:{}", msg, value);
    }
}

Issue Links

• links to: GitHub Pull Request #1758