[ZOOKEEPER-4294] FileSnap#findNValidSnapshots should not declare IOException

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.8.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Wenjun Ruan
• Created: 16/May/21 15:59
• Updated: 22/Sep/21 13:15
• Resolved: 22/Sep/21 11:06

Description

The IOException has already been caught

protected List<File> findNValidSnapshots(int n) throws IOException {
    List<File> files = Util.sortDataDir(snapDir.listFiles(), SNAPSHOT_FILE_PREFIX, false);
    int count = 0;
    List<File> list = new ArrayList<File>();
    for (File f : files) {
        // we should catch the exceptions
        // from the valid snapshot and continue
        // until we find a valid one
        try {
            if (SnapStream.isValidSnapshot(f)) {
                list.add(f);
                count++;
                if (count == n) {
                    break;
                }
            }
        } catch (IOException e) {
            LOG.warn("invalid snapshot {}", f, e);
        }
    }
    return list;
}

Issue Links

• links to: GitHub Pull Request #1752