[ZOOKEEPER-4232] InvalidSnapshotTest corrupts its own test data

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.10, 3.6.3, 3.7.0, 3.8.0
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Damien Diederen
• Created: 06/Mar/21 18:08
• Updated: 28/Mar/21 08:53
• Resolved: 09/Mar/21 17:18

Description

InvalidSnapshotTest.testSnapshot starts an instance of ZooKeeperServer on the version-controlled invalidsnap directory, which, as a side-effect, "fixes" the following snapshot—which is broken on purpose (see ZOOKEEPER-367):

zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f

This status quo creates a number of problems:

1. It makes the test ineffective after the first run;
2. The file shows as modified in version control tools, which can be annoying;
3. The "fixed" snapshot can end up being committed by mistake, invalidating the test.

(#3 is not theoretical; that "fixed" snapshot frequently shows up in pull requests, and was recently merged into master.).

Issue Links

• links to: GitHub Pull Request #1622
• links to: GitHub Pull Request #1627
• links to: GitHub Pull Request #1628
• links to: GitHub Pull Request #1629