[ZOOKEEPER-4232] InvalidSnapshotTest corrupts its own test data - ASF JIRA

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.5.10, 3.6.3, 3.7.0, 3.8.0
Component/s: None
Labels:
- pull-request-available

Description

InvalidSnapshotTest.testSnapshot starts an instance of ZooKeeperServer on the version-controlled invalidsnap directory, which, as a side-effect, "fixes" the following snapshot—which is broken on purpose (see ~~ZOOKEEPER-367~~):

zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f

This status quo creates a number of problems:

It makes the test ineffective after the first run;
The file shows as modified in version control tools, which can be annoying;
The "fixed" snapshot can end up being committed by mistake, invalidating the test.

(#3 is not theoretical; that "fixed" snapshot frequently shows up in pull requests, and was recently merged into master.).