[ZOOKEEPER-4204] Flaky test - RequestPathMetricsCollectorTest.testMultiThreadPerf

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.8.0
• Fix Version/s: 3.8.0, 3.7.1
• Component/s: tests
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Amichai Rothman
• Created: 08/Feb/21 13:09
• Updated: 28/Jul/21 13:34
• Resolved: 28/Jul/21 13:31

Description

This test sometimes fails on a laptop. Timed performance tests in unit tests can be problematic in general due to the variety of hardware it might run on, but I have a little fix that reduces the test overhead and tightens the timing, so it's a good first step (and works for me).

 

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)

Issue Links

• links to: GitHub Pull Request #1598