[ZOOKEEPER-4201] C client: SASL-related compilation issues on macOS Catalina

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.7.0, 3.8.0
• Component/s: c client
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Damien Diederen
• Created: 04/Feb/21 19:25
• Updated: 28/Mar/21 08:54
• Resolved: 17/Feb/21 19:26

Description

Originally reported by eolivelli:

   [exec] .../apache-zookeeper-3.7.0/zookeeper-client/zookeeper-client-c/src/cli.c:960:14: error: 'sasl_client_init' is deprecated: first deprecated in macOS 10.11 [-Werror,-Wdeprecated-declarations]
   [exec]     sr = sasl_client_init(NULL);
   [exec]       ^
   [exec]
   [...]

The above is in cli.c, but similar issues also arise when compiling zk_sasl.c, which is part of the client library.

Enrico also wrote:

And if I remove "-Werror" I get

[exec] .../apache-zookeeper-3.7.0/zookeeper-client/zookeeper-client-c/tests/LibCSymTable.h:85:36: error: unknown type name 'clockid_t'; did you mean 'clock_t'?
   [exec]   DECLARE_SYM(int,clock_gettime,(clockid_t clk_id, struct timespec*));
   [exec]                  ^~~~~~~~~
   [exec]                  clock_t

but this happens in the test suite, which does not currently work on macOS due to the --wrap option, which is not supported by the native linker. Fixing the test suite is considered out of scope for this ticket.

Issue Links

• links to: GitHub Pull Request #1593