ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-414

zkServer.sh is duplicated in a couple of places

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.6.0
    • Component/s: None
    • Labels:
      None

      Description

      we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used.

        Activity

        Michi Mutsuzaki made changes -
        Fix Version/s 3.6.0 [ 12326518 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Mahadev konar made changes -
        Fix Version/s 3.5.0 [ 12316644 ]
        Fix Version/s 3.4.0 [ 12314469 ]
        Patrick Hunt made changes -
        Field Original Value New Value
        Fix Version/s 3.4.0 [ 12314469 ]
        Fix Version/s 3.3.0 [ 12313976 ]
        Hide
        Mahadev konar added a comment -

        I meant having a testzkServer.sh that calls zkServer.sh, also we should think about putting the testzkserver.sh in src/java/test and not in bin so that it doesnt cause any confusion for folks.

        Show
        Mahadev konar added a comment - I meant having a testzkServer.sh that calls zkServer.sh, also we should think about putting the testzkserver.sh in src/java/test and not in bin so that it doesnt cause any confusion for folks.
        Hide
        Mahadev konar added a comment -

        we should go with the second one. The first one would just be a disaster waiting to happen .

        Show
        Mahadev konar added a comment - we should go with the second one. The first one would just be a disaster waiting to happen .
        Hide
        Steven Cheng added a comment -

        Current list of zkServer.sh files:

        ./src/contrib/zkpython/src/test/zkServer.sh
        ./src/contrib/rest/src/test/zkServer.sh
        ./src/c/tests/zkServer.sh
        ./src/recipes/queue/src/c/tests/zkServer.sh
        ./src/recipes/lock/src/c/tests/zkServer.sh
        ./bin/zkServer.sh

        All of the extra ones are for testing. Looked into this a bit, main difference between bin/zkServer.sh and the testing scripts is that the testing scripts delete the zookeeper data. I'm guessing that it wouldn't be helpful to have "zkServer.sh delete"?

        One option is to create bin/testzkServer.sh that handles the deleting and calls zkServer.sh as needed. Then a conf file just needs to be created and the test suites can be hooked in to the new script.

        Show
        Steven Cheng added a comment - Current list of zkServer.sh files: ./src/contrib/zkpython/src/test/zkServer.sh ./src/contrib/rest/src/test/zkServer.sh ./src/c/tests/zkServer.sh ./src/recipes/queue/src/c/tests/zkServer.sh ./src/recipes/lock/src/c/tests/zkServer.sh ./bin/zkServer.sh All of the extra ones are for testing. Looked into this a bit, main difference between bin/zkServer.sh and the testing scripts is that the testing scripts delete the zookeeper data. I'm guessing that it wouldn't be helpful to have "zkServer.sh delete"? One option is to create bin/testzkServer.sh that handles the deleting and calls zkServer.sh as needed. Then a conf file just needs to be created and the test suites can be hooked in to the new script.
        Hide
        Mahadev konar added a comment -

        agreed... .

        Show
        Mahadev konar added a comment - agreed... .
        Benjamin Reed created issue -

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Benjamin Reed
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development