[ZOOKEEPER-4033] Remove unnecessary judgment of null

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: LiAoNan
• Created: 23/Dec/20 05:48
• Updated: 28/Mar/21 08:53
• Resolved: 24/Dec/20 17:13

Description

in the method of `QuorumPeerMain.runFromConfig`

        try {
            metricsProvider = MetricsProviderBootstrap.startMetricsProvider(
                config.getMetricsProviderClassName(),
                config.getMetricsProviderConfiguration());
        } catch (MetricsProviderLifeCycleException error) {
            throw new IOException("Cannot boot MetricsProvider " + config.getMetricsProviderClassName(), error);
        }

causing exception or metricsProvider will never be null

        try {
             ...
        } finally {
            if (metricsProvider != null) {
                try {
                    metricsProvider.stop();
                } catch (Throwable error) {
                    LOG.warn("Error while stopping metrics", error);
                }
            }
        }

So there's no need to check again in the finally code block.
remove it

finally {
            try {
                metricsProvider.stop();
            } catch (Throwable error) {
                LOG.warn("Error while stopping metrics", error);
            }
        }

Issue Links

• links to: GitHub Pull Request #1562