[ZOOKEEPER-4001] AuditHelper.addAuditLog(...) more readable

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.8.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: zengchao
• Created: 13/Nov/20 02:50
• Updated: 23/Sep/21 01:58
• Resolved: 02/Feb/21 07:12

Description

if (failedTxn) {
    CreateRequest createRequest = new CreateRequest();
    deserialize(request, createRequest);
    path = createRequest.getPath();
    createMode =
            getCreateMode(createRequest);
} else {
    createMode = getCreateMode(request);
}

may modified to 

CreateRequest createRequest = new CreateRequest();
deserialize(request, createRequest);
createMode = getCreateMode(createRequest);
if (failedTxn) {
    path = createRequest.getPath();
}

the getCreateMode(request) is this

private static String getCreateMode(Request request) throws IOException, KeeperException {
    CreateRequest createRequest = new CreateRequest();
    deserialize(request, createRequest);
    return getCreateMode(createRequest);
}

is this change more readable?

Issue Links

• links to: GitHub Pull Request #1535
• links to: GitHub Pull Request #1537