[ZOOKEEPER-3992] addWatch api should check the null watch

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.3, 3.7.0, 3.8.0
• Component/s: java client
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Ling Mao
• Created: 03/Nov/20 13:23
• Updated: 04/Apr/21 05:24
• Resolved: 09/Nov/20 11:21

Description

public void addWatch(String basePath, Watcher watcher, AddWatchMode mode)
        throws KeeperException, InterruptedException {
    PathUtils.validatePath(basePath);
    String serverPath = prependChroot(basePath);

    RequestHeader h = new RequestHeader();
    h.setType(ZooDefs.OpCode.addWatch);
    AddWatchRequest request = new AddWatchRequest(serverPath, mode.getMode());
    ReplyHeader r = cnxn.submitRequest(h, request, new ErrorResponse(),
    

we need to validateWatcher(watcher) to ** avoid the case:

zk.addWatch("/a/b", null, PERSISTENT_RECURSIVE);

Issue Links

• links to: GitHub Pull Request #1529
• links to: GitHub Pull Request #1531