[ZOOKEEPER-3926] make the rc constant in the ClientCnxn

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Ling Mao
• Created: 04/Sep/20 09:53
• Updated: 28/Mar/21 08:54
• Resolved: 28/Oct/20 10:21

Description

Lots of codes about the result code in the callback(ClientCnxn.EventThread#processEvent) is hardcode. For example:

} else if (p.response instanceof GetACLResponse) {
    ACLCallback cb = (ACLCallback) p.cb;
    GetACLResponse rsp = (GetACLResponse) p.response;
    if (rc == 0) {
        cb.processResult(rc, clientPath, p.ctx, rsp.getAcl(), rsp.getStat());
    } else {
        cb.processResult(rc, clientPath, p.ctx, null, null);
    }
}

This makes the codes difficult to maintain. What we want looks like this:

if (rc == Code.OK.intValue()) {
   ////////////////////////
}

 

Issue Links

• links to: GitHub Pull Request #1497