[ZOOKEEPER-3782] Replace filter with list comprehension for returning list in zk-merge-pr.py

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Labels: pull-request-available
• Assignee: Zili Chen
• Reporter: Zili Chen
• Created: 01/Apr/20 15:23
• Updated: 28/Mar/21 08:55
• Resolved: 08/Apr/20 12:05

Description

After Py3, filter return a filter object instead of list object, which causes

Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable

We can replace filter with list comprehension to fix it.

Issue Links

• links to: GitHub Pull Request #1303