[ZOOKEEPER-3760] remove a useless throwing CliException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.7
• Fix Version/s: 3.6.1, 3.5.8
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Jinjiang Ling
• Created: 17/Mar/20 00:51
• Updated: 11/May/20 15:41
• Resolved: 26/Mar/20 17:47

Description

when I upgrade zookeeper from 3.4.13 to 3.5.7 in my application, I find the function processCmd in ZooKeeperMain.java is just like blow

protected boolean processCmd(MyCommandOptions co) throws CliException, IOException, InterruptedException {
    boolean watch = false;
    try {
        watch = processZKCmd(co);
        exitCode = ExitCode.EXECUTION_FINISHED.getValue();
    } catch (CliException ex) {
        exitCode = ex.getExitCode();
        System.err.println(ex.getMessage());
    }
    return watch;
}

it throws CliException which has been caught in the funciton, so I think it can be removed.

Issue Links

• links to: GitHub Pull Request #1286