[ZOOKEEPER-3728] move traceMask calculation logic into the trace log in the FinalRequestProcessor#processRequest

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Brittany Barnes
• Reporter: Ling Mao
• Created: 15/Feb/20 12:21
• Updated: 28/Mar/21 08:54
• Resolved: 26/Mar/20 21:14

Description

LOG.debug("Processing request:: {}", request);

// request.addRQRec(">final");
long traceMask = ZooTrace.CLIENT_REQUEST_TRACE_MASK;
if (request.type == OpCode.ping) {
    traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
}
if (LOG.isTraceEnabled()) {
    ZooTrace.logRequest(LOG, traceMask, 'E', request, "");
}

1. remove the useless // request.addRQRec(">final");
2.  most read/write requests will hit the code here but useless when Log Trace disable. we need to move traceMask calculation logic into the LOG.isTraceEnabled()

Issue Links

• links to: GitHub Pull Request #1271