Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-3728

move traceMask calculation logic into the trace log in the FinalRequestProcessor#processRequest

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.7.0
    • Component/s: server

      Description

      LOG.debug("Processing request:: {}", request);
      
      // request.addRQRec(">final");
      long traceMask = ZooTrace.CLIENT_REQUEST_TRACE_MASK;
      if (request.type == OpCode.ping) {
          traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
      }
      if (LOG.isTraceEnabled()) {
          ZooTrace.logRequest(LOG, traceMask, 'E', request, "");
      }
      
      1. remove the useless // request.addRQRec(">final");
      2.  most read/write requests will hit the code here but useless when Log Trace disable. we need to move traceMask calculation logic into the LOG.isTraceEnabled()

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                blb93 Brittany Barnes
                Reporter:
                maoling maoling
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m