[ZOOKEEPER-3708] Move Logging Code into Logging Guard in Learner

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0, 3.5.7, 3.6.1
• Labels: newbie noob pull-request-available
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 31/Jan/20 00:01
• Updated: 14/Feb/20 15:23
• Resolved: 03/Feb/20 03:32

Description

Learner.java

    void readPacket(QuorumPacket pp) throws IOException {
...
        long traceMask = ZooTrace.SERVER_PACKET_TRACE_MASK;
        if (pp.getType() == Leader.PING) {
            traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
        }
        if (LOG.isTraceEnabled()) {
            ZooTrace.logQuorumPacket(LOG, traceMask, 'i', pp);
        }
    }

The traceMask only matters if trace is enabled, so move it and the associated code into the logging guard.

Issue Links

• links to: GitHub Pull Request #1240