[ZOOKEEPER-3662] Remove NPE Possibility in Follower Class

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Labels: pull-request-available
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 23/Dec/19 17:58
• Updated: 28/Mar/21 08:54
• Resolved: 03/Nov/20 16:03

Description

Follower.java

    public long getZxid() {
        try {
            synchronized (fzk) {
                return fzk.getZxid();
            }
        } catch (NullPointerException e) {
            LOG.warn("error getting zxid", e);
        }
        return -1;
    }

I traced the code and there is no reason to catch a NPE here. Add additional restrictions to make sure NPE will never happen.

Issue Links

• links to: GitHub Pull Request #1192