[ZOOKEEPER-3651] NettyServerCnxnFactoryTest is flaky

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.6
• Fix Version/s: 3.6.0, 3.7.0
• Labels: pull-request-available

Release Note

committed to master branch as 20daae7d5fa934629e7825ed72e66ad76a94d6aa

committed also to branch-3.6

But I cannot merge it to branch-3.5 as the patch does not apply cleanly

• Assignee: Mate Szalay-Beko
• Reporter: Mate Szalay-Beko
• Created: 16/Dec/19 10:25
• Updated: 28/Mar/21 08:54
• Resolved: 16/Dec/19 21:13

Description

NettyServerCnxnFactoryTest is flaky, it fails from time to time on jenkins.

e.g. https://builds.apache.org/view/ZK%20All/job/zookeeper-master-maven/557/org.apache.zookeeper$zookeeper/testReport/org.apache.zookeeper.server/NettyServerCnxnFactoryTest/testOutstandingHandshakeLimit/

 

INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.NettyServerCnxnFactoryTest
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
7.339 s <<< FAILURE! - in
org.apache.zookeeper.server.NettyServerCnxnFactoryTest
[ERROR]
testOutstandingHandshakeLimit(org.apache.zookeeper.server.NettyServerCnxnFactoryTest)
 Time elapsed: 6.569 s  <<< FAILURE!
java.lang.AssertionError:

Expected: is <true>
     but: was <false>
at
org.apache.zookeeper.server.NettyServerCnxnFactoryTest.testOutstandingHandshakeLimit(NettyServerCnxnFactoryTest.java:142)

Issue Links

• links to: GitHub Pull Request #1184