[ZOOKEEPER-3570] make the special client xid constant

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Ling Mao
• Reporter: Ling Mao
• Created: 08/Oct/19 07:31
• Updated: 21/Nov/19 05:14
• Resolved: 21/Nov/19 04:59

Description

in the ClientCnxn, we had hard-code cxid which is not elegant.

we need a constant for cxid

if (replyHdr.getXid() == -2) {
    // -2 is the xid for pings
    if (LOG.isDebugEnabled()) {
        LOG.debug("Got ping response for sessionid: 0x"
                  + Long.toHexString(sessionId)
                  + " after "
                  + ((System.nanoTime() - lastPingSentNs) / 1000000)
                  + "ms");
    }
    return;
}
if (replyHdr.getXid() == -4) {
    // -4 is the xid for AuthPacket
    if (replyHdr.getErr() == KeeperException.Code.AUTHFAILED.intValue()) {
        state = States.AUTH_FAILED;
        eventThread.queueEvent(new WatchedEvent(Watcher.Event.EventType.None, Watcher.Event.KeeperState.AuthFailed, null));
        eventThread.queueEventOfDeath();
    }
    if (LOG.isDebugEnabled()) {
        LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId));
    }
    return;
}
if (replyHdr.getXid() == -1) {

Issue Links

• links to: GitHub Pull Request #1136