[ZOOKEEPER-3539] Fix branch-3.5 after upgrade on ASF CI

• Type: Task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.5.5
• Fix Version/s: 3.5.6
• Component/s: build, build-infrastructure
• Labels: pull-request-available
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 08/Sep/19 08:06
• Updated: 31/Mar/20 10:49
• Resolved: 09/Sep/19 11:49

Description

ASF CI now lacks "findbugs" tool.
ASF CI upgraded gcc and now there are some errors related to the usage of NULL in calls of fprintf.

We should:

• disable findbugs on CI ant-based tasks
• use LOG_DEBUG consistently with the rest of code in C client

Please note that on branch-3.5 we are officially using Maven and Spotbugs, ant stuff is there only for compatibility in build, findbugs is not strictly needed to check the goodness of code in branch-3.5.

branch-3.4 is only with ANT, let's treat this problem as a different task

Issue Links

• links to: GitHub Pull Request #1082
• links to: GitHub Pull Request #1160