[ZOOKEEPER-3457] Code optimization in QuorumCnxManager

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.5.5
• Fix Version/s: 3.6.0
• Component/s: quorum
• Labels: easyfix pull-request-available
• Release Note: https://github.com/apache/zookeeper/pull/1021
• Assignee: tom.long
• Reporter: tom.long
• Created: 08/Jul/19 06:28
• Updated: 27/Jul/19 23:12
• Resolved: 27/Jul/19 18:05

Description

Dear developer:
I think the following code in line 623 of the QuorumCnxManager class can be optimized:

ArrayBlockingQueue<ByteBuffer> bq = new ArrayBlockingQueue<ByteBuffer>(
SEND_CAPACITY);
ArrayBlockingQueue<ByteBuffer> oldq = queueSendMap.putIfAbsent(sid, bq);
if (oldq != null) {
addToSendQueue(oldq, b);
} else {
addToSendQueue(bq, b);
}

The optimization is as follows:

ArrayBlockingQueue<ByteBuffer> bq = queueSendMap.computeIfAbsent(sid, serverId 
 -> new ArrayBlockingQueue<>(SEND_CAPACITY));
addToSendQueue(bq, b);