[ZOOKEEPER-3364] Compile with strict options in order to check code quality

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.0
• Component/s: build
• Labels: pull-request-available
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 13/Apr/19 20:12
• Updated: 22/May/19 05:06
• Resolved: 08/May/19 19:55

Description

In order to dismiss old QA tests based on ant (ZOOKEEPER-3351) we have to enforce code quality by activating some falgs on javac at build time, namely:

 

<compilerArgs>
   <compilerArg>-Werror</compilerArg>
   <compilerArg>-Xlint:deprecation</compilerArg>
   <compilerArg>-Xlint:unchecked</compilerArg>
   <!-- https://issues.apache.org/jira/browse/MCOMPILER-205 -->
   <compilerArg>-Xpkginfo:always</compilerArg>
</compilerArgs>

Issue Links

• links to: GitHub Pull Request #910
• links to: GitHub Pull Request #952