[ZOOKEEPER-3302] ZooKeeper C client does not compile on Fedora 29

• Type: Wish
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.0
• Component/s: c client
• Labels: pull-request-available
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 09/Mar/19 13:12
• Updated: 10/Apr/19 00:27
• Resolved: 09/Apr/19 08:08

Description

I cannot build current master (git sha 372e713a9d2d9264417313e5d68e9437ffddd0f5)  with Fedora 29

 

gcc --version
gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)

 

This is the error:

    [exec] gcc -DHAVE_CONFIG_H -I. -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c  -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated   -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f 'src/cli.c' || echo '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
     [exec] /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c: In function ‘main’:
     [exec] /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9: error: ‘strncpy’ specified bound 1024 equals destination size [-Werror=stringop-truncation]
     [exec]          strncpy(cmd, argv[2]+4, sizeof(cmd));
     [exec]          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     [exec] cc1: all warnings being treated as errors
     [exec] make: *** [Makefile:1155: cli.o] Error 1

Issue Links

• links to: GitHub Pull Request #846