[ZOOKEEPER-3215] Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.13
• Fix Version/s: 3.7.0, 3.5.8, 3.6.2
• Labels: pull-request-available
• Assignee: Andor Molnar
• Reporter: V
• Created: 13/Dec/18 20:54
• Updated: 11/May/20 15:41
• Resolved: 30/Apr/20 07:30

Description

Java 9 introduces covariant return types which allows one to have different return types if return type in the overridden method is a sub type. Since Java 9, few functions return ByteBuffer, whereas the parent method return Buffer, resulting in causing issues for Java 8 and below since for them the method does not exist.

Steps To Reproduce:
1. Setup ZooKeeper Server with JDK11.
2. Setup ZooKeeper Client with JDK8.
3. Try connecting the client and server.

Results:
Cast ByteBuffer instances to Buffer before calling the method.

 

Notes:
There was a similar bug in the MongoDB community - https://jira.mongodb.org/browse/JAVA-2559

 

This is not a contribution.

Issue Links

• links to: GitHub Pull Request #760