[ZOOKEEPER-3157] Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Andor Molnar
• Reporter: Fangmin Lv
• Created: 28/Sep/18 05:53
• Updated: 12/Aug/23 04:40
• Resolved: 08/Oct/18 12:45

Description

hanm noticed that the test might failure because of ConnectionLoss when trying to getData, here is an example, we should catch this and retry to avoid flaky.

Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase, which is the base class for most of the tests. I'm not sure this is the right way to go or not, since it's actually 'hiding' the flaky tests, but this will help reducing the flaky tests a lot if we're not going to tackle it in the near time, and we can check the testing history to find out which tests are flaky and deal with them separately. So let me know if this seems to provide any benefit in short term, if it is I'll provide a patch to do that.

Issue Links

• relates to: ZOOKEEPER-4734 FuzzySnapshotRelatedTest becomes flaky when transient disk failure appears
• links to: GitHub Pull Request #657