[ZOOKEEPER-3059] EventThread leak in case of Sasl AuthFailed

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.4.12
• Fix Version/s: 3.6.0, 3.5.5
• Labels: pull-request-available
• Assignee: Abhishek Singh Chouhan
• Reporter: Abhishek Singh Chouhan
• Created: 11/Jun/18 17:21
• Updated: 04/Oct/19 14:55
• Resolved: 25/Jun/18 10:31

Description

In case of an authFailed sasl event we shutdown the send thread however we never close the event thread. Even if the client tries to close the connection it results in a no-op since we check for cnxn.getState().isAlive() which results in negative for auth failed state and we return without cleaning up. For applications that retry in case of auth failed by closing the existing connection and then trying to reconnect(eg. hbase replication) this eventually ends up exhausting the system resources.

Issue Links

• duplicates: ZOOKEEPER-2407 EventThread in ClientCnxn can't be closed when SendThread exits because of auth failed during reconnection
• links to: GitHub Pull Request #541