[ZOOKEEPER-3012] Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.3, 3.4.11
• Fix Version/s: 3.5.4, 3.6.0, 3.4.13
• Component/s: server, tests
• Labels: unit-test
• Hadoop Flags: Reviewed
• Assignee: Andor Molnar
• Reporter: Andor Molnar
• Created: 27/Mar/18 15:19
• Updated: 17/Jul/18 04:49
• Resolved: 09/May/18 22:21

Description

The following arrange methods uses hard coded values:

when(configMock.getDataDir()).thenReturn("/tmp/zookeeper");
when(configMock.getDataLogDir()).thenReturn("/tmp/zookeeperLog");

Which makes the test fail if the folders exist on the running machine.

Random test folders should be created and removed during cleanup.

Issue Links

• links to: GitHub Pull Request #514
• links to: GitHub Pull Request #515