ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-3

syncLimit has slightly different comments in the class header, and > inline with the variable.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: quorum
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      syncLimit as documented in QuorumPeer is documented twice with two different aspects of in each instance. It should be better documented and unified. (Probably remove the second instance.)

      1. ZOOKEEPER-3.patch
        0.8 kB
        Mahadev konar

        Activity

        Benjamin Reed created issue -
        Mahadev konar made changes -
        Field Original Value New Value
        Summary  syncLimit has slightly different comments in the class header, and
        > inline with the variable.
         syncLimit has slightly different comments in the class header, and > inline with the variable.
        Fix Version/s 3.3.0 [ 12313976 ]
        Hide
        Mahadev konar added a comment -

        this patch removes redundant javadocs. Very trivial patch. no tests.

        Show
        Mahadev konar added a comment - this patch removes redundant javadocs. Very trivial patch. no tests.
        Mahadev konar made changes -
        Attachment ZOOKEEPER-3.patch [ 12425142 ]
        Mahadev konar made changes -
        Assignee Mahadev konar [ mahadev ]
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12425142/ZOOKEEPER-3.patch
        against trunk revision 835618.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425142/ZOOKEEPER-3.patch against trunk revision 835618. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        Committed revision 881849.

        Show
        Benjamin Reed added a comment - Committed revision 881849.
        Benjamin Reed made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #545 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/545/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #545 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/545/ )
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Cassandra #402 (See http://hudson.zones.apache.org/hudson/job/Cassandra/402/)
        r/m contrib/mutex/lib/zookeeper-3.2.2.jar

        Show
        Hudson added a comment - Integrated in Cassandra #402 (See http://hudson.zones.apache.org/hudson/job/Cassandra/402/ ) r/m contrib/mutex/lib/zookeeper-3.2.2.jar

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Benjamin Reed
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development