Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2999

CMake build should use target-level commands

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4, 3.6.0
    • Fix Version/s: 3.5.4, 3.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Originally suggested in GitHub PR #386, the CMake build I wrote used include_directories, which has global side effects, instead of the more explicit target_include_directories, to include directories per target (and with private or public scoping).

      Furthermore, it should also use CMAKE_CURRENT_SOURCE_DIR over CMAKE_SOURCE_DIR in order to allow inclusion in other projects via add_subdirectory(), and we can reduce the minimally required CMake version to 3.5 from 3.6.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                andschwa Andrew Schwartzmeyer
                Reporter:
                andschwa Andrew Schwartzmeyer
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: