[ZOOKEEPER-2949] SSL ServerName not set when using hostname, some proxies may failed to proxy the request.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.3
• Fix Version/s: 3.5.4, 3.6.0
• Component/s: java client

Environment

In our environment, the zk clusters are all behind a proxy, the proxy decide to transfer the request from client based on the "ServerName" field in SSL Hello packet(the proxy served on SSL only). but the Hello packets that zk client sended do proxy do not contain the "ServerName" field in it. after inspect the codes, we have found that it is because that zk client did not specify the peerHost when initializing the SSLContext.

• Tags: ssl proxy
• Assignee: Unassigned
• Reporter: Feng Shaobao
• Created: 27/Nov/17 03:26
• Updated: 30/Jan/18 21:26
• Resolved: 30/Jan/18 20:58

Description

In our environment, the zk clusters are all behind a proxy, the proxy decide to transfer the request from client based on the "ServerName" field in SSL Hello packet(the proxy served on SSL only). but the Hello packets that zk client sended do proxy do not contain the "ServerName" field in it. after inspect the codes, we have found that it is because that zk client did not specify the peerHost when initializing the SSLContext.

In the method initSSL of class ZKClientPipelineFactory, it initialize the SSLEngine like below:

sslEngine = sslContext.createSSLEngine();

Actually the sslContext provide another factory method that receives the hostName and port parameter.

public final SSLEngine createSSLEngine(String hostName, int port)

If we call this method to create the SSLEngine, then the proxy will know which zk cluster it really want to access.

Issue Links

• links to: GitHub Pull Request #423