Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2936

Duplicate Keys in log4j.properties config files

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.4.8, 3.5.3, 3.6.0
    • Fix Version/s: 3.5.4, 3.6.0, 3.4.12
    • Component/s: contrib, other
    • Labels:
      None
    • Environment:

      Apache ZooKeeper source tarball

      Description

      Recent versions of ZooKeeper have introduced the following duplicate keys in to the contrib log4j.properties files.

      In this file:

      ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties
      

      and this file:

      ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties
      

      the following duplicate keys are found:

      log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
      log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n
      

      This was discovered because I've written file validators for most major formats which recurse all my github repos and this was failing my integration tests when pulling ZooKeeper source code. I actually added --exclude and --ignore-duplicate-keys switches to

      validate_ini.py

      to work around this and fix my builds for now but just remembered to raise this to you guys.

      The validator tools if you're interested can be found at:

      https://github.com/harisekhon/pytools

      Cheers

      Hari

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                harisekhon Hari Sekhon
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: