[ZOOKEEPER-2907] Logged request buffer isn't useful

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.10, 3.5.3
• Fix Version/s: 3.8.0
• Component/s: server
• Labels: pull-request-available
• Assignee: Nishanth Entoor
• Reporter: Jordan Zimmerman
• Created: 28/Sep/17 20:40
• Updated: 18/Dec/21 14:12
• Resolved: 18/Dec/21 14:12

Description

There are two places in the server code that log request errors with a message ala "Dumping request buffer..." followed by a hex dump of the request buffer. There are 2 major problems with this output:

1. The request type is not output
2. The byte-to-hex inline code doesn't pad numbers < 16

These two combine to make the output data nearly useless.

PrepRequestProcessor#pRequest() and FinalRequestProcessor#processRequest()

Issue Links

• links to: GitHub Pull Request #1221