Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2892

Improve lazy initialize and close stream for `PrepRequestProcessor`

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: server
    • Labels:
      None

      Description

      Improve lazy initialize and close stream for `PrepRequestProcessor`

      • Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables
      • Close the `ByteArrayOutputStream` I/O stream

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user asdf2014 opened a pull request:

          https://github.com/apache/zookeeper/pull/361

          ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor`

          Improve lazy initialize and close stream for `PrepRequestProcessor`

          • Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables
          • Close the `ByteArrayOutputStream` I/O stream

          @hanm PTAL

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/361.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #361


          commit 3b053f2fe57b3b4bc52dac29134b6f68e7b48c6d
          Author: asdf2014 <benedictjin2016@gmail.com>
          Date: 2017-09-06T02:02:28Z

          ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor`


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user asdf2014 opened a pull request: https://github.com/apache/zookeeper/pull/361 ZOOKEEPER-2892 : Improve lazy initialize and close stream for `PrepRequestProcessor` Improve lazy initialize and close stream for `PrepRequestProcessor` Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables Close the `ByteArrayOutputStream` I/O stream @hanm PTAL You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #361 commit 3b053f2fe57b3b4bc52dac29134b6f68e7b48c6d Author: asdf2014 <benedictjin2016@gmail.com> Date: 2017-09-06T02:02:28Z ZOOKEEPER-2892 : Improve lazy initialize and close stream for `PrepRequestProcessor`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 commented on the issue:

          https://github.com/apache/zookeeper/pull/361

          Seems like jenkins cannot work normally? @hanm

          ```bash
          GitHub pull request #361 to apache/zookeeper
          [EnvInject] - Loading node environment variables.
          ERROR: SEVERE ERROR occurs
          org.jenkinsci.lib.envinject.EnvInjectException: java.io.IOException: Remote call on H5 failed
          at org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:86)
          at org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:43)
          at hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:528)
          at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:448)
          at hudson.model.Run.execute(Run.java:1735)
          at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
          at hudson.model.ResourceController.execute(ResourceController.java:97)
          at hudson.model.Executor.run(Executor.java:405)
          Caused by: java.io.IOException: Remote call on H5 failed
          at hudson.remoting.Channel.call(Channel.java:838)
          at hudson.FilePath.act(FilePath.java:1081)
          at org.jenkinsci.plugins.envinject.service.EnvInjectActionSetter.addEnvVarsToRun(EnvInjectActionSetter.java:59)
          at org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:83)
          ... 7 more
          Caused by: java.lang.OutOfMemoryError: Java heap space
          ERROR: Step ?Archive the artifacts? failed: no workspace for PreCommit-ZOOKEEPER-github-pr-build #998
          ERROR: Step ?Publish JUnit test result report? failed: no workspace for PreCommit-ZOOKEEPER-github-pr-build #998
          [description-setter] Could not determine description.
          Putting comment on the pull request
          [EnvInject] - [ERROR] - SEVERE ERROR occurs: Remote call on H5 failed
          Email was triggered for: Failure - Any
          Sending email for trigger: Failure - Any
          Sending email to: dev@zookeeper.apache.org
          Warning: this build has no associated authentication, so build permissions may be lacking, and downstream projects which cannot even be seen by an anonymous user will be silently skipped
          Finished: FAILURE
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/361 Seems like jenkins cannot work normally? @hanm ```bash GitHub pull request #361 to apache/zookeeper [EnvInject] - Loading node environment variables. ERROR: SEVERE ERROR occurs org.jenkinsci.lib.envinject.EnvInjectException: java.io.IOException: Remote call on H5 failed at org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:86) at org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:43) at hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:528) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:448) at hudson.model.Run.execute(Run.java:1735) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:405) Caused by: java.io.IOException: Remote call on H5 failed at hudson.remoting.Channel.call(Channel.java:838) at hudson.FilePath.act(FilePath.java:1081) at org.jenkinsci.plugins.envinject.service.EnvInjectActionSetter.addEnvVarsToRun(EnvInjectActionSetter.java:59) at org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:83) ... 7 more Caused by: java.lang.OutOfMemoryError: Java heap space ERROR: Step ?Archive the artifacts? failed: no workspace for PreCommit-ZOOKEEPER-github-pr-build #998 ERROR: Step ?Publish JUnit test result report? failed: no workspace for PreCommit-ZOOKEEPER-github-pr-build #998 [description-setter] Could not determine description. Putting comment on the pull request [EnvInject] - [ERROR] - SEVERE ERROR occurs: Remote call on H5 failed Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Sending email to: dev@zookeeper.apache.org Warning: this build has no associated authentication, so build permissions may be lacking, and downstream projects which cannot even be seen by an anonymous user will be silently skipped Finished: FAILURE ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hanm commented on the issue:

          https://github.com/apache/zookeeper/pull/361

          Looks like a transient error, you can try retrigger Jenkins job by closing and reopening the pull request, or just generate a new commit hash (git commit --amend) and force push to remote.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/361 Looks like a transient error, you can try retrigger Jenkins job by closing and reopening the pull request, or just generate a new commit hash (git commit --amend) and force push to remote.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 commented on the issue:

          https://github.com/apache/zookeeper/pull/361

          Okay, I'll try it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/361 Okay, I'll try it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 closed the pull request at:

          https://github.com/apache/zookeeper/pull/361

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 closed the pull request at: https://github.com/apache/zookeeper/pull/361
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user asdf2014 reopened a pull request:

          https://github.com/apache/zookeeper/pull/361

          ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor`

          Improve lazy initialize and close stream for `PrepRequestProcessor`

          • Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables
          • Close the `ByteArrayOutputStream` I/O stream

          @hanm PTAL

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/361.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #361


          commit 14ea808d169c0f3df9529fe4353a31c6f595337b
          Author: asdf2014 <benedictjin2016@gmail.com>
          Date: 2017-09-06T02:02:28Z

          ZOOKEEPER-2892: Improve lazy initialize & close stream for `PrepRequestProcessor`


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user asdf2014 reopened a pull request: https://github.com/apache/zookeeper/pull/361 ZOOKEEPER-2892 : Improve lazy initialize and close stream for `PrepRequestProcessor` Improve lazy initialize and close stream for `PrepRequestProcessor` Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables Close the `ByteArrayOutputStream` I/O stream @hanm PTAL You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #361 commit 14ea808d169c0f3df9529fe4353a31c6f595337b Author: asdf2014 <benedictjin2016@gmail.com> Date: 2017-09-06T02:02:28Z ZOOKEEPER-2892 : Improve lazy initialize & close stream for `PrepRequestProcessor`
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/999//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 commented on the issue:

          https://github.com/apache/zookeeper/pull/361

          @hanm It works, thx a lot. 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/361 @hanm It works, thx a lot. 👍
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1023//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1024//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 commented on the issue:

          https://github.com/apache/zookeeper/pull/361

          @hanm Thanks for your suggestion. Conflicts has been fixed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/361 @hanm Thanks for your suggestion. Conflicts has been fixed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asdf2014 closed the pull request at:

          https://github.com/apache/zookeeper/pull/361

          Show
          githubbot ASF GitHub Bot added a comment - Github user asdf2014 closed the pull request at: https://github.com/apache/zookeeper/pull/361
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user asdf2014 reopened a pull request:

          https://github.com/apache/zookeeper/pull/361

          ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor`

          Improve lazy initialize and close stream for `PrepRequestProcessor`

          • Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables
          • Close the `ByteArrayOutputStream` I/O stream

          @hanm PTAL

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/361.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #361


          commit 2237131f3e54cf20eb751ff61ce2cf4f8edc5e3e
          Author: asdf2014 <benedictjin2016@gmail.com>
          Date: 2017-09-12T01:18:43Z

          ZOOKEEPER-2892: Improve lazy initialize & close stream for `PrepRequestProcessor`


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user asdf2014 reopened a pull request: https://github.com/apache/zookeeper/pull/361 ZOOKEEPER-2892 : Improve lazy initialize and close stream for `PrepRequestProcessor` Improve lazy initialize and close stream for `PrepRequestProcessor` Delay the initialization of `ChangeRecord` and `ReconfigRequest` variables Close the `ByteArrayOutputStream` I/O stream @hanm PTAL You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2892 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #361 commit 2237131f3e54cf20eb751ff61ce2cf4f8edc5e3e Author: asdf2014 <benedictjin2016@gmail.com> Date: 2017-09-12T01:18:43Z ZOOKEEPER-2892 : Improve lazy initialize & close stream for `PrepRequestProcessor`
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1031//console This message is automatically generated.

            People

            • Assignee:
              benedict jin Benedict Jin
              Reporter:
              benedict jin Benedict Jin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development