[ZOOKEEPER-2856] ZooKeeperSaslClient#respondToServer should log exception message of SaslException

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.10, 3.5.3
• Fix Version/s: 3.4.11, 3.5.4, 3.6.0
• Assignee: Pan Yuxuan
• Reporter: Pan Yuxuan
• Created: 25/Jul/17 09:34
• Updated: 27/Jul/17 01:35
• Resolved: 27/Jul/17 00:25

Description

When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes get error in HBase logs like:

SASL authentication failed using login context 'Client'.

This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer :

 catch (SaslException e) {
                LOG.error("SASL authentication failed using login context '" +
                        this.getLoginContext() + "'.");
                saslState = SaslState.FAILED;
                gotLastPacket = true;
  }

This error makes user confused without explicit exception message. So I think we can add exception message to the log.

Issue Links

• links to: GitHub Pull Request #318