Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2814

Ignore space after comma in connection string

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I'm using the following connection string:

      10.0.0.179:2181,<space>10.0.0.176:2181

      However, I get:

      {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
      at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
      at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
      at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
      at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
      at java.net.InetAddress.getAllByName(InetAddress.java:1192)
      at java.net.InetAddress.getAllByName(InetAddress.java:1126)
      at org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:61)
      at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:445)
      at ...
      ...}}

      The problem was the space after the comma. I suggest to either make the space optional or produce error on it, as this is a real pain to spot. Using the space also makes the connect string more readable. Spaces are not allowed in domain names.

        Issue Links

          Activity

          Hide
          nikbhi Nikhil Ashok Bhide added a comment -

          Spaces are not allowed in the domain space. So, would it be good idea to trim the spaces and use the address or throw exception that IP address/host name of server can not contain space? According to me, its better to throw the exception rather than trimming spaces of provided IP address.

          Show
          nikbhi Nikhil Ashok Bhide added a comment - Spaces are not allowed in the domain space. So, would it be good idea to trim the spaces and use the address or throw exception that IP address/host name of server can not contain space? According to me, its better to throw the exception rather than trimming spaces of provided IP address.
          Hide
          nikbhi15 Nikhil Bhide added a comment -

          Please assign this to me.

          Show
          nikbhi15 Nikhil Bhide added a comment - Please assign this to me.
          Hide
          eribeiro Edward Ribeiro added a comment -

          Hi Nikhil Bhide,

          FYI, the trim of the host string seems to be fixed on branch-3.5 and master, doesn't it? See https://github.com/apache/zookeeper/blob/branch-3.5/src/java/main/org/apache/zookeeper/common/StringUtils.java#L37

          While it is not fixed on branch-3.4 yet: https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/client/ConnectStringParser.java#L65

          I suggest that you add a method to check the host string with spaces after (and before) the comma.

          Show
          eribeiro Edward Ribeiro added a comment - Hi Nikhil Bhide , FYI, the trim of the host string seems to be fixed on branch-3.5 and master, doesn't it? See https://github.com/apache/zookeeper/blob/branch-3.5/src/java/main/org/apache/zookeeper/common/StringUtils.java#L37 While it is not fixed on branch-3.4 yet: https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/client/ConnectStringParser.java#L65 I suggest that you add a method to check the host string with spaces after (and before) the comma.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide opened a pull request:

          https://github.com/apache/zookeeper/pull/343

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Proposed changes:

          • StringUtils.java
          • New class org.apache.zookeeper.common.StringUtils to be added
          • Logic to split trim the spaces to be added in split method
          • ConnectStringParser
          • Instead of using String#split, use StringUtils#split

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/zookeeper master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/343.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #343


          commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-05-20T07:29:50Z

          ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status command execution result misleads user (J.Andreina via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 13f79535-47bb-0310-9956-ffa450edef68

          commit 111d60b6253e3e2911a6ff525f0af792e7793ce5
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-05-22T05:24:39Z

          ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task (Chris Nauroth via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 13f79535-47bb-0310-9956-ffa450edef68

          commit 3a7a240ef7381edf15925045e9f94408177e51cd
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-29T17:45:53Z

          ZOOKEEPER-2187: remove duplicated code between CreateRequest

          {,2}

          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 13f79535-47bb-0310-9956-ffa450edef68

          commit fe63c1c4fdbfce201e193cd8723488d9a40dc498
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-05-29T19:48:23Z

          ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 13f79535-47bb-0310-9956-ffa450edef68

          commit 63884670328f09a3814db54cb4644d683822e4d4
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-29T21:46:49Z

          ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 13f79535-47bb-0310-9956-ffa450edef68

          commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-30T16:39:30Z

          ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 13f79535-47bb-0310-9956-ffa450edef68

          commit 891b12d004842e6ea09509765eaa2a18eca727c4
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2015-05-31T09:21:07Z

          ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 13f79535-47bb-0310-9956-ffa450edef68

          commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2015-06-01T06:45:11Z

          ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 13f79535-47bb-0310-9956-ffa450edef68

          commit 7f52bebb90ff2d61a2428013771ce0df09890876
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-02T05:21:26Z

          ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java

          To be able to use utf-8 in .java source files we now use utf-8
          encoding to build them (Michi Mutsuzaki via rgs).

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 13f79535-47bb-0310-9956-ffa450edef68

          commit ea500b8911223fb36555b12c391adc9a20c9e28d
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-02T19:17:09Z

          ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 2010+
          (Vitaly Stakhovsky via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 13f79535-47bb-0310-9956-ffa450edef68

          commit 9f89dd30187a48e39556b6305246d835b54e00ae
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T16:26:06Z

          ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of its
          children set (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683587 13f79535-47bb-0310-9956-ffa450edef68

          commit feb90fabcab3a14b075eb56f2618e6483acfebfb
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T17:37:26Z

          ZOOKEEPER-2204: LearnerSnapshotThrottlerTest.testHighContentionWithTimeout
          fails occasionally (Donny Nadolny via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683602 13f79535-47bb-0310-9956-ffa450edef68

          commit 78b84f3ae01ca477fb94404c78bf3a098b0fcba4
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T17:51:16Z

          ZOOKEEPER-2163: Introduce new ZNode type: container
          (Jordan Zimmerman via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683605 13f79535-47bb-0310-9956-ffa450edef68

          commit ee7ff36dcbbd3ea1dac690c7fe15891ac6fc87e2
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T18:38:41Z

          ZOOKEEPER-2205: Log type of unexpected quorum packet in learner handler loop
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683833 13f79535-47bb-0310-9956-ffa450edef68

          commit 5847d0d15ffc2f13d513b189d73125e98700e850
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T18:51:44Z

          ZOOKEEPER-2206: Add missing packet types to LearnerHandler.packetToString()
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683842 13f79535-47bb-0310-9956-ffa450edef68

          commit b90a32fa1518c4f6c46d5c7d25cda4937a4f496f
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:15:36Z

          ZOOKEEPER-2207: Enhance error logs with LearnerHandler.packetToString()
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683848 13f79535-47bb-0310-9956-ffa450edef68

          commit ec3ee9469aeff60d65de38fa91bf4e6ca9f6a28a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:25:41Z

          ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683850 13f79535-47bb-0310-9956-ffa450edef68

          commit bedcfed45550b59d088e556ce463e1fdcba3242b
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:28:23Z

          ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
          (update CHANGES.txt) (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683851 13f79535-47bb-0310-9956-ffa450edef68

          commit 71dd96a232cb590e90601fde4bfafcd4eef1f82a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-06T01:48:52Z

          ZOOKEEPER-2201: Network issues can cause cluster to hang due to near-deadlock
          (Donny Nadolny via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683878 13f79535-47bb-0310-9956-ffa450edef68

          commit 9bee4674c015a71785daeb7a6da93676a3450699
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-11T18:09:19Z

          ZOOKEEPER-2213: Empty path in Set crashes server and prevents restart
          (Hongchao Deng via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1684956 13f79535-47bb-0310-9956-ffa450edef68

          commit b58a0621fb0f3495d7c010308d2822f245a56a00
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-12T21:02:55Z

          ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
          store to local variable (Hongchao Deng via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68

          commit 2d94a794d33a27567b37b772c08316277ee4e547
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-13T00:42:49Z

          ZOOKEEPER-706: Large numbers of watches can cause session re-establishment to fail
          (Chris Thunes via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685200 13f79535-47bb-0310-9956-ffa450edef68

          commit 6a2f5e3e76f85e7aeba72f94397315bec96ea4f1
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-15T23:05:25Z

          ZOOKEEPER-2212: distributed race condition related to QV version
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685685 13f79535-47bb-0310-9956-ffa450edef68

          commit 61df2ce2aeda8df79fa3f33c07cac23b9f6b1ca3
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-18T19:23:18Z

          ZOOKEEPER-2185: Run server with -XX:+HeapDumpOnOutOfMemoryError and
          -XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686296 13f79535-47bb-0310-9956-ffa450edef68

          commit b9c65eb6be6959639eb691642d60a88960888b49
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-22T00:18:57Z

          ZOOKEEPER-2210: clock_gettime is not available in OS X
          (Michi Mutsuzaki via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686767 13f79535-47bb-0310-9956-ffa450edef68

          commit c520e1e826d88955db7637a33cd4f20c20c0bd7a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-27T00:03:30Z

          ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously
          (Yasuhito Fukuda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1687876 13f79535-47bb-0310-9956-ffa450edef68

          commit 352022265deb93110b7370e0fc2df6809985a60a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-28T19:09:49Z

          ZOOKEEPER-2140: NettyServerCnxn and NIOServerCnxn code should be improved
          (Arshad Mohammad via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688041 13f79535-47bb-0310-9956-ffa450edef68

          commit a61b4e1b528cb4c70627e9f9295b34bb05a79303
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-30T18:50:11Z

          ZOOKEEPER-2221: Zookeeper JettyAdminServer server should start on configured IP
          (Surendra Singh Lilhore via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688505 13f79535-47bb-0310-9956-ffa450edef68

          commit 9a9d587861606884cca5b4a532078f925b50e40c
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-07-05T04:05:33Z

          ZOOKEEPER-2224: Four letter command hangs when network is slow (Arshad Mohammad via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689211 13f79535-47bb-0310-9956-ffa450edef68

          commit 3c9c66ac68e430a435b6bd02a9ab5cde03f31e11
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-07-07T05:11:49Z

          ZOOKEEPER-2223: support method-level JUnit testcase
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689571 13f79535-47bb-0310-9956-ffa450edef68


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/343 ZOOKEEPER-2814 : Ignore space after comma in connection string Proposed changes: StringUtils.java New class org.apache.zookeeper.common.StringUtils to be added Logic to split trim the spaces to be added in split method ConnectStringParser Instead of using String#split, use StringUtils#split You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820 Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-05-20T07:29:50Z ZOOKEEPER-2156 : If JAVA_HOME is not set zk startup and fetching status command execution result misleads user (J.Andreina via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 13f79535-47bb-0310-9956-ffa450edef68 commit 111d60b6253e3e2911a6ff525f0af792e7793ce5 Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-05-22T05:24:39Z ZOOKEEPER-2191 : Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task (Chris Nauroth via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 13f79535-47bb-0310-9956-ffa450edef68 commit 3a7a240ef7381edf15925045e9f94408177e51cd Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-29T17:45:53Z ZOOKEEPER-2187 : remove duplicated code between CreateRequest {,2} (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 13f79535-47bb-0310-9956-ffa450edef68 commit fe63c1c4fdbfce201e193cd8723488d9a40dc498 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-05-29T19:48:23Z ZOOKEEPER-2179 : Typo in Watcher.java (Archana T via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 13f79535-47bb-0310-9956-ffa450edef68 commit 63884670328f09a3814db54cb4644d683822e4d4 Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-29T21:46:49Z ZOOKEEPER-2189 : QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 13f79535-47bb-0310-9956-ffa450edef68 commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-30T16:39:30Z ZOOKEEPER-2189 : QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 13f79535-47bb-0310-9956-ffa450edef68 commit 891b12d004842e6ea09509765eaa2a18eca727c4 Author: Michi Mutsuzaki <michim@apache.org> Date: 2015-05-31T09:21:07Z ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 13f79535-47bb-0310-9956-ffa450edef68 commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7 Author: Michi Mutsuzaki <michim@apache.org> Date: 2015-06-01T06:45:11Z ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 13f79535-47bb-0310-9956-ffa450edef68 commit 7f52bebb90ff2d61a2428013771ce0df09890876 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-02T05:21:26Z ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java To be able to use utf-8 in .java source files we now use utf-8 encoding to build them (Michi Mutsuzaki via rgs). git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 13f79535-47bb-0310-9956-ffa450edef68 commit ea500b8911223fb36555b12c391adc9a20c9e28d Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-02T19:17:09Z ZOOKEEPER-2096 : C client builds with incorrect error codes in VisualStudio 2010+ (Vitaly Stakhovsky via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 13f79535-47bb-0310-9956-ffa450edef68 commit 9f89dd30187a48e39556b6305246d835b54e00ae Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T16:26:06Z ZOOKEEPER-2194 : Let DataNode.getChildren() return an unmodifiable view of its children set (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683587 13f79535-47bb-0310-9956-ffa450edef68 commit feb90fabcab3a14b075eb56f2618e6483acfebfb Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T17:37:26Z ZOOKEEPER-2204 : LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally (Donny Nadolny via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683602 13f79535-47bb-0310-9956-ffa450edef68 commit 78b84f3ae01ca477fb94404c78bf3a098b0fcba4 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T17:51:16Z ZOOKEEPER-2163 : Introduce new ZNode type: container (Jordan Zimmerman via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683605 13f79535-47bb-0310-9956-ffa450edef68 commit ee7ff36dcbbd3ea1dac690c7fe15891ac6fc87e2 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T18:38:41Z ZOOKEEPER-2205 : Log type of unexpected quorum packet in learner handler loop (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683833 13f79535-47bb-0310-9956-ffa450edef68 commit 5847d0d15ffc2f13d513b189d73125e98700e850 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T18:51:44Z ZOOKEEPER-2206 : Add missing packet types to LearnerHandler.packetToString() (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683842 13f79535-47bb-0310-9956-ffa450edef68 commit b90a32fa1518c4f6c46d5c7d25cda4937a4f496f Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:15:36Z ZOOKEEPER-2207 : Enhance error logs with LearnerHandler.packetToString() (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683848 13f79535-47bb-0310-9956-ffa450edef68 commit ec3ee9469aeff60d65de38fa91bf4e6ca9f6a28a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:25:41Z ZOOKEEPER-2208 : Log type of unexpected quorum packet in observer loop (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683850 13f79535-47bb-0310-9956-ffa450edef68 commit bedcfed45550b59d088e556ce463e1fdcba3242b Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:28:23Z ZOOKEEPER-2208 : Log type of unexpected quorum packet in observer loop (update CHANGES.txt) (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683851 13f79535-47bb-0310-9956-ffa450edef68 commit 71dd96a232cb590e90601fde4bfafcd4eef1f82a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-06T01:48:52Z ZOOKEEPER-2201 : Network issues can cause cluster to hang due to near-deadlock (Donny Nadolny via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683878 13f79535-47bb-0310-9956-ffa450edef68 commit 9bee4674c015a71785daeb7a6da93676a3450699 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-11T18:09:19Z ZOOKEEPER-2213 : Empty path in Set crashes server and prevents restart (Hongchao Deng via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1684956 13f79535-47bb-0310-9956-ffa450edef68 commit b58a0621fb0f3495d7c010308d2822f245a56a00 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-12T21:02:55Z ZOOKEEPER-2214 : Findbugs warning: LearnerHandler.packetToString Dead store to local variable (Hongchao Deng via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68 commit 2d94a794d33a27567b37b772c08316277ee4e547 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-13T00:42:49Z ZOOKEEPER-706 : Large numbers of watches can cause session re-establishment to fail (Chris Thunes via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685200 13f79535-47bb-0310-9956-ffa450edef68 commit 6a2f5e3e76f85e7aeba72f94397315bec96ea4f1 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-15T23:05:25Z ZOOKEEPER-2212 : distributed race condition related to QV version (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685685 13f79535-47bb-0310-9956-ffa450edef68 commit 61df2ce2aeda8df79fa3f33c07cac23b9f6b1ca3 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-18T19:23:18Z ZOOKEEPER-2185 : Run server with -XX:+HeapDumpOnOutOfMemoryError and -XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686296 13f79535-47bb-0310-9956-ffa450edef68 commit b9c65eb6be6959639eb691642d60a88960888b49 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-22T00:18:57Z ZOOKEEPER-2210 : clock_gettime is not available in OS X (Michi Mutsuzaki via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686767 13f79535-47bb-0310-9956-ffa450edef68 commit c520e1e826d88955db7637a33cd4f20c20c0bd7a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-27T00:03:30Z ZOOKEEPER-2193 : reconfig command completes even if parameter is wrong obviously (Yasuhito Fukuda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1687876 13f79535-47bb-0310-9956-ffa450edef68 commit 352022265deb93110b7370e0fc2df6809985a60a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-28T19:09:49Z ZOOKEEPER-2140 : NettyServerCnxn and NIOServerCnxn code should be improved (Arshad Mohammad via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688041 13f79535-47bb-0310-9956-ffa450edef68 commit a61b4e1b528cb4c70627e9f9295b34bb05a79303 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-30T18:50:11Z ZOOKEEPER-2221 : Zookeeper JettyAdminServer server should start on configured IP (Surendra Singh Lilhore via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688505 13f79535-47bb-0310-9956-ffa450edef68 commit 9a9d587861606884cca5b4a532078f925b50e40c Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-07-05T04:05:33Z ZOOKEEPER-2224 : Four letter command hangs when network is slow (Arshad Mohammad via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689211 13f79535-47bb-0310-9956-ffa450edef68 commit 3c9c66ac68e430a435b6bd02a9ab5cde03f31e11 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-07-07T05:11:49Z ZOOKEEPER-2223 : support method-level JUnit testcase (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689571 13f79535-47bb-0310-9956-ffa450edef68
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide closed the pull request at:

          https://github.com/apache/zookeeper/pull/343

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide closed the pull request at: https://github.com/apache/zookeeper/pull/343
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide commented on the issue:

          https://github.com/apache/zookeeper/pull/343

          Reopening pull request #343

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide commented on the issue: https://github.com/apache/zookeeper/pull/343 Reopening pull request #343
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide reopened a pull request:

          https://github.com/apache/zookeeper/pull/343

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Proposed changes:

          • StringUtils.java
          • New class org.apache.zookeeper.common.StringUtils to be added
          • Logic to split trim the spaces to be added in split method
          • ConnectStringParser.java
          • Instead of using String#split, use StringUtils#split

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/zookeeper master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/343.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #343


          commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-05-20T07:29:50Z

          ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status command execution result misleads user (J.Andreina via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 13f79535-47bb-0310-9956-ffa450edef68

          commit 111d60b6253e3e2911a6ff525f0af792e7793ce5
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-05-22T05:24:39Z

          ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task (Chris Nauroth via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 13f79535-47bb-0310-9956-ffa450edef68

          commit 3a7a240ef7381edf15925045e9f94408177e51cd
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-29T17:45:53Z

          ZOOKEEPER-2187: remove duplicated code between CreateRequest

          {,2}

          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 13f79535-47bb-0310-9956-ffa450edef68

          commit fe63c1c4fdbfce201e193cd8723488d9a40dc498
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-05-29T19:48:23Z

          ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 13f79535-47bb-0310-9956-ffa450edef68

          commit 63884670328f09a3814db54cb4644d683822e4d4
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-29T21:46:49Z

          ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 13f79535-47bb-0310-9956-ffa450edef68

          commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a
          Author: Hongchao Deng <hdeng@apache.org>
          Date: 2015-05-30T16:39:30Z

          ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
          (Raul Gutierrez Segales via hdeng)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 13f79535-47bb-0310-9956-ffa450edef68

          commit 891b12d004842e6ea09509765eaa2a18eca727c4
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2015-05-31T09:21:07Z

          ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 13f79535-47bb-0310-9956-ffa450edef68

          commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2015-06-01T06:45:11Z

          ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 13f79535-47bb-0310-9956-ffa450edef68

          commit 7f52bebb90ff2d61a2428013771ce0df09890876
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-02T05:21:26Z

          ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java

          To be able to use utf-8 in .java source files we now use utf-8
          encoding to build them (Michi Mutsuzaki via rgs).

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 13f79535-47bb-0310-9956-ffa450edef68

          commit ea500b8911223fb36555b12c391adc9a20c9e28d
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-02T19:17:09Z

          ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 2010+
          (Vitaly Stakhovsky via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 13f79535-47bb-0310-9956-ffa450edef68

          commit 9f89dd30187a48e39556b6305246d835b54e00ae
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T16:26:06Z

          ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of its
          children set (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683587 13f79535-47bb-0310-9956-ffa450edef68

          commit feb90fabcab3a14b075eb56f2618e6483acfebfb
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T17:37:26Z

          ZOOKEEPER-2204: LearnerSnapshotThrottlerTest.testHighContentionWithTimeout
          fails occasionally (Donny Nadolny via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683602 13f79535-47bb-0310-9956-ffa450edef68

          commit 78b84f3ae01ca477fb94404c78bf3a098b0fcba4
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-04T17:51:16Z

          ZOOKEEPER-2163: Introduce new ZNode type: container
          (Jordan Zimmerman via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683605 13f79535-47bb-0310-9956-ffa450edef68

          commit ee7ff36dcbbd3ea1dac690c7fe15891ac6fc87e2
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T18:38:41Z

          ZOOKEEPER-2205: Log type of unexpected quorum packet in learner handler loop
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683833 13f79535-47bb-0310-9956-ffa450edef68

          commit 5847d0d15ffc2f13d513b189d73125e98700e850
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T18:51:44Z

          ZOOKEEPER-2206: Add missing packet types to LearnerHandler.packetToString()
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683842 13f79535-47bb-0310-9956-ffa450edef68

          commit b90a32fa1518c4f6c46d5c7d25cda4937a4f496f
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:15:36Z

          ZOOKEEPER-2207: Enhance error logs with LearnerHandler.packetToString()
          (Hitoshi Mitake via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683848 13f79535-47bb-0310-9956-ffa450edef68

          commit ec3ee9469aeff60d65de38fa91bf4e6ca9f6a28a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:25:41Z

          ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683850 13f79535-47bb-0310-9956-ffa450edef68

          commit bedcfed45550b59d088e556ce463e1fdcba3242b
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-05T19:28:23Z

          ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
          (update CHANGES.txt) (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683851 13f79535-47bb-0310-9956-ffa450edef68

          commit 71dd96a232cb590e90601fde4bfafcd4eef1f82a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-06T01:48:52Z

          ZOOKEEPER-2201: Network issues can cause cluster to hang due to near-deadlock
          (Donny Nadolny via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683878 13f79535-47bb-0310-9956-ffa450edef68

          commit 9bee4674c015a71785daeb7a6da93676a3450699
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-11T18:09:19Z

          ZOOKEEPER-2213: Empty path in Set crashes server and prevents restart
          (Hongchao Deng via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1684956 13f79535-47bb-0310-9956-ffa450edef68

          commit b58a0621fb0f3495d7c010308d2822f245a56a00
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-12T21:02:55Z

          ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
          store to local variable (Hongchao Deng via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68

          commit 2d94a794d33a27567b37b772c08316277ee4e547
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-13T00:42:49Z

          ZOOKEEPER-706: Large numbers of watches can cause session re-establishment to fail
          (Chris Thunes via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685200 13f79535-47bb-0310-9956-ffa450edef68

          commit 6a2f5e3e76f85e7aeba72f94397315bec96ea4f1
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-15T23:05:25Z

          ZOOKEEPER-2212: distributed race condition related to QV version
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685685 13f79535-47bb-0310-9956-ffa450edef68

          commit 61df2ce2aeda8df79fa3f33c07cac23b9f6b1ca3
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-18T19:23:18Z

          ZOOKEEPER-2185: Run server with -XX:+HeapDumpOnOutOfMemoryError and
          -XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686296 13f79535-47bb-0310-9956-ffa450edef68

          commit b9c65eb6be6959639eb691642d60a88960888b49
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-22T00:18:57Z

          ZOOKEEPER-2210: clock_gettime is not available in OS X
          (Michi Mutsuzaki via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686767 13f79535-47bb-0310-9956-ffa450edef68

          commit c520e1e826d88955db7637a33cd4f20c20c0bd7a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-27T00:03:30Z

          ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously
          (Yasuhito Fukuda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1687876 13f79535-47bb-0310-9956-ffa450edef68

          commit 352022265deb93110b7370e0fc2df6809985a60a
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-28T19:09:49Z

          ZOOKEEPER-2140: NettyServerCnxn and NIOServerCnxn code should be improved
          (Arshad Mohammad via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688041 13f79535-47bb-0310-9956-ffa450edef68

          commit a61b4e1b528cb4c70627e9f9295b34bb05a79303
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-06-30T18:50:11Z

          ZOOKEEPER-2221: Zookeeper JettyAdminServer server should start on configured IP
          (Surendra Singh Lilhore via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688505 13f79535-47bb-0310-9956-ffa450edef68

          commit 9a9d587861606884cca5b4a532078f925b50e40c
          Author: Rakesh Radhakrishnan <rakeshr@apache.org>
          Date: 2015-07-05T04:05:33Z

          ZOOKEEPER-2224: Four letter command hangs when network is slow (Arshad Mohammad via rakeshr)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689211 13f79535-47bb-0310-9956-ffa450edef68

          commit 3c9c66ac68e430a435b6bd02a9ab5cde03f31e11
          Author: Raúl Gutiérrez Segalés <rgs@apache.org>
          Date: 2015-07-07T05:11:49Z

          ZOOKEEPER-2223: support method-level JUnit testcase
          (Akihiro Suda via rgs)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689571 13f79535-47bb-0310-9956-ffa450edef68


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide reopened a pull request: https://github.com/apache/zookeeper/pull/343 ZOOKEEPER-2814 : Ignore space after comma in connection string Proposed changes: StringUtils.java New class org.apache.zookeeper.common.StringUtils to be added Logic to split trim the spaces to be added in split method ConnectStringParser.java Instead of using String#split, use StringUtils#split You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820 Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-05-20T07:29:50Z ZOOKEEPER-2156 : If JAVA_HOME is not set zk startup and fetching status command execution result misleads user (J.Andreina via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 13f79535-47bb-0310-9956-ffa450edef68 commit 111d60b6253e3e2911a6ff525f0af792e7793ce5 Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-05-22T05:24:39Z ZOOKEEPER-2191 : Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task (Chris Nauroth via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 13f79535-47bb-0310-9956-ffa450edef68 commit 3a7a240ef7381edf15925045e9f94408177e51cd Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-29T17:45:53Z ZOOKEEPER-2187 : remove duplicated code between CreateRequest {,2} (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 13f79535-47bb-0310-9956-ffa450edef68 commit fe63c1c4fdbfce201e193cd8723488d9a40dc498 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-05-29T19:48:23Z ZOOKEEPER-2179 : Typo in Watcher.java (Archana T via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 13f79535-47bb-0310-9956-ffa450edef68 commit 63884670328f09a3814db54cb4644d683822e4d4 Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-29T21:46:49Z ZOOKEEPER-2189 : QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 13f79535-47bb-0310-9956-ffa450edef68 commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a Author: Hongchao Deng <hdeng@apache.org> Date: 2015-05-30T16:39:30Z ZOOKEEPER-2189 : QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 13f79535-47bb-0310-9956-ffa450edef68 commit 891b12d004842e6ea09509765eaa2a18eca727c4 Author: Michi Mutsuzaki <michim@apache.org> Date: 2015-05-31T09:21:07Z ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 13f79535-47bb-0310-9956-ffa450edef68 commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7 Author: Michi Mutsuzaki <michim@apache.org> Date: 2015-06-01T06:45:11Z ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 13f79535-47bb-0310-9956-ffa450edef68 commit 7f52bebb90ff2d61a2428013771ce0df09890876 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-02T05:21:26Z ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java To be able to use utf-8 in .java source files we now use utf-8 encoding to build them (Michi Mutsuzaki via rgs). git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 13f79535-47bb-0310-9956-ffa450edef68 commit ea500b8911223fb36555b12c391adc9a20c9e28d Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-02T19:17:09Z ZOOKEEPER-2096 : C client builds with incorrect error codes in VisualStudio 2010+ (Vitaly Stakhovsky via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 13f79535-47bb-0310-9956-ffa450edef68 commit 9f89dd30187a48e39556b6305246d835b54e00ae Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T16:26:06Z ZOOKEEPER-2194 : Let DataNode.getChildren() return an unmodifiable view of its children set (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683587 13f79535-47bb-0310-9956-ffa450edef68 commit feb90fabcab3a14b075eb56f2618e6483acfebfb Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T17:37:26Z ZOOKEEPER-2204 : LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally (Donny Nadolny via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683602 13f79535-47bb-0310-9956-ffa450edef68 commit 78b84f3ae01ca477fb94404c78bf3a098b0fcba4 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-04T17:51:16Z ZOOKEEPER-2163 : Introduce new ZNode type: container (Jordan Zimmerman via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683605 13f79535-47bb-0310-9956-ffa450edef68 commit ee7ff36dcbbd3ea1dac690c7fe15891ac6fc87e2 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T18:38:41Z ZOOKEEPER-2205 : Log type of unexpected quorum packet in learner handler loop (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683833 13f79535-47bb-0310-9956-ffa450edef68 commit 5847d0d15ffc2f13d513b189d73125e98700e850 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T18:51:44Z ZOOKEEPER-2206 : Add missing packet types to LearnerHandler.packetToString() (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683842 13f79535-47bb-0310-9956-ffa450edef68 commit b90a32fa1518c4f6c46d5c7d25cda4937a4f496f Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:15:36Z ZOOKEEPER-2207 : Enhance error logs with LearnerHandler.packetToString() (Hitoshi Mitake via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683848 13f79535-47bb-0310-9956-ffa450edef68 commit ec3ee9469aeff60d65de38fa91bf4e6ca9f6a28a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:25:41Z ZOOKEEPER-2208 : Log type of unexpected quorum packet in observer loop (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683850 13f79535-47bb-0310-9956-ffa450edef68 commit bedcfed45550b59d088e556ce463e1fdcba3242b Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-05T19:28:23Z ZOOKEEPER-2208 : Log type of unexpected quorum packet in observer loop (update CHANGES.txt) (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683851 13f79535-47bb-0310-9956-ffa450edef68 commit 71dd96a232cb590e90601fde4bfafcd4eef1f82a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-06T01:48:52Z ZOOKEEPER-2201 : Network issues can cause cluster to hang due to near-deadlock (Donny Nadolny via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683878 13f79535-47bb-0310-9956-ffa450edef68 commit 9bee4674c015a71785daeb7a6da93676a3450699 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-11T18:09:19Z ZOOKEEPER-2213 : Empty path in Set crashes server and prevents restart (Hongchao Deng via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1684956 13f79535-47bb-0310-9956-ffa450edef68 commit b58a0621fb0f3495d7c010308d2822f245a56a00 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-12T21:02:55Z ZOOKEEPER-2214 : Findbugs warning: LearnerHandler.packetToString Dead store to local variable (Hongchao Deng via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68 commit 2d94a794d33a27567b37b772c08316277ee4e547 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-13T00:42:49Z ZOOKEEPER-706 : Large numbers of watches can cause session re-establishment to fail (Chris Thunes via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685200 13f79535-47bb-0310-9956-ffa450edef68 commit 6a2f5e3e76f85e7aeba72f94397315bec96ea4f1 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-15T23:05:25Z ZOOKEEPER-2212 : distributed race condition related to QV version (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685685 13f79535-47bb-0310-9956-ffa450edef68 commit 61df2ce2aeda8df79fa3f33c07cac23b9f6b1ca3 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-18T19:23:18Z ZOOKEEPER-2185 : Run server with -XX:+HeapDumpOnOutOfMemoryError and -XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686296 13f79535-47bb-0310-9956-ffa450edef68 commit b9c65eb6be6959639eb691642d60a88960888b49 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-22T00:18:57Z ZOOKEEPER-2210 : clock_gettime is not available in OS X (Michi Mutsuzaki via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686767 13f79535-47bb-0310-9956-ffa450edef68 commit c520e1e826d88955db7637a33cd4f20c20c0bd7a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-27T00:03:30Z ZOOKEEPER-2193 : reconfig command completes even if parameter is wrong obviously (Yasuhito Fukuda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1687876 13f79535-47bb-0310-9956-ffa450edef68 commit 352022265deb93110b7370e0fc2df6809985a60a Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-28T19:09:49Z ZOOKEEPER-2140 : NettyServerCnxn and NIOServerCnxn code should be improved (Arshad Mohammad via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688041 13f79535-47bb-0310-9956-ffa450edef68 commit a61b4e1b528cb4c70627e9f9295b34bb05a79303 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-06-30T18:50:11Z ZOOKEEPER-2221 : Zookeeper JettyAdminServer server should start on configured IP (Surendra Singh Lilhore via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688505 13f79535-47bb-0310-9956-ffa450edef68 commit 9a9d587861606884cca5b4a532078f925b50e40c Author: Rakesh Radhakrishnan <rakeshr@apache.org> Date: 2015-07-05T04:05:33Z ZOOKEEPER-2224 : Four letter command hangs when network is slow (Arshad Mohammad via rakeshr) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689211 13f79535-47bb-0310-9956-ffa450edef68 commit 3c9c66ac68e430a435b6bd02a9ab5cde03f31e11 Author: Raúl Gutiérrez Segalés <rgs@apache.org> Date: 2015-07-07T05:11:49Z ZOOKEEPER-2223 : support method-level JUnit testcase (Akihiro Suda via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689571 13f79535-47bb-0310-9956-ffa450edef68
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide commented on the issue:

          https://github.com/apache/zookeeper/pull/343

          Closing pull request #343 as there seems to be a conflict.

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide commented on the issue: https://github.com/apache/zookeeper/pull/343 Closing pull request #343 as there seems to be a conflict.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide closed the pull request at:

          https://github.com/apache/zookeeper/pull/343

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide closed the pull request at: https://github.com/apache/zookeeper/pull/343
          Hide
          nikbhi15 Nikhil Bhide added a comment -

          Hi Admin,
          As per the guidelines, I forked out new branch, made the changes and opened a new pull request.
          https://github.com/apache/zookeeper/pull/345
          Build was passed successfully, but I can not check in the changes. Can you please review the changes and give me write access so that I can commit the changes to Zookeeper- branch 3.4 and close this issue.

          Show
          nikbhi15 Nikhil Bhide added a comment - Hi Admin, As per the guidelines, I forked out new branch, made the changes and opened a new pull request. https://github.com/apache/zookeeper/pull/345 Build was passed successfully, but I can not check in the changes. Can you please review the changes and give me write access so that I can commit the changes to Zookeeper- branch 3.4 and close this issue.
          Hide
          hanm Michael Han added a comment -

          Thanks for working on this.

          give me write access so that I can commit the changes to Zookeeper- branch 3.4 and close this issue.

          This is not the way Apache works. Please read contributor guidelines at https://community.apache.org/contributors/. tldr: only committers have access to source repo.

          Show
          hanm Michael Han added a comment - Thanks for working on this. give me write access so that I can commit the changes to Zookeeper- branch 3.4 and close this issue. This is not the way Apache works. Please read contributor guidelines at https://community.apache.org/contributors/ . tldr: only committers have access to source repo.
          Hide
          nikbhi15 Nikhil Bhide added a comment -

          Thanks Michael Han for the update.
          Can you please let me know steps to check-in the changes?

          Show
          nikbhi15 Nikhil Bhide added a comment - Thanks Michael Han for the update. Can you please let me know steps to check-in the changes?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide opened a pull request:

          https://github.com/apache/zookeeper/pull/368

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Ported ZOOKEEPER-2814 from master to branch 3.4.

          Added files
          src/java/main/org/apache/zookeeper/common/StringUtils.java
          src/java/test/org/apache/zookeeper/test/StringUtilTest.java

          Modified Files:
          src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
          src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/368.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #368


          commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:14:29Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space after comma in connection string
          Port ZOOKEEPER-2814 from master

          commit 3f210394e989507282d1e42fb9f3e35512d314e8
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:19:44Z

          Zookeeper 2814: ignore space after comma in connection string

          Port Zookeeper 2814 from master to branch - 3.4
          Created StringUtils.java

          commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:22:26Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added code to test split logic implemented in StringUtils.java

          commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:26:08Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added test to verify the logic added to remove the spaces provided in connection string


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/368 ZOOKEEPER-2814 : Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:14:29Z ZOOKEEPER-2814 : Ignore space after comma in connection string Added logic to trim host connection string for ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master commit 3f210394e989507282d1e42fb9f3e35512d314e8 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:19:44Z Zookeeper 2814: ignore space after comma in connection string Port Zookeeper 2814 from master to branch - 3.4 Created StringUtils.java commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:22:26Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added code to test split logic implemented in StringUtils.java commit 1629f64f58c7787bb993162e5c9b8565b4d45c64 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:26:08Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added test to verify the logic added to remove the spaces provided in connection string
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide closed the pull request at:

          https://github.com/apache/zookeeper/pull/368

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide closed the pull request at: https://github.com/apache/zookeeper/pull/368
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide opened a pull request:

          https://github.com/apache/zookeeper/pull/369

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Ported ZOOKEEPER-2814 from master to branch 3.4.

          Added files
          src/java/main/org/apache/zookeeper/common/StringUtils.java
          src/java/test/org/apache/zookeeper/test/StringUtilTest.java

          Modified Files:
          src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
          src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/369.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #369


          commit 6503f12e144bc6b0652f7adf558bdc28c984e6c0
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-15T18:12:07Z

          ZOOKEEPER-1786. ZooKeeper data model documentation is incorrect
          (Niraj Tolia via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542356 13f79535-47bb-0310-9956-ffa450edef68

          commit a452d791cff92d65937142c3475a9894264376f6
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-16T10:06:19Z

          ZOOKEEPER-1808. Add version to FLE notifications for 3.4 branch (fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542489 13f79535-47bb-0310-9956-ffa450edef68

          commit b770aeb0c8bcb28a9b653b1dc0edac623c75b509
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-17T11:42:22Z

          ZOOKEEPER-1597. Windows build failing (michim via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542710 13f79535-47bb-0310-9956-ffa450edef68

          commit 7f069c0e084a74f6de661267b828ff3fde30bd11
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-23T18:21:38Z

          ZOOKEEPER-1817. Fix don't care for b3.4 (fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1544858 13f79535-47bb-0310-9956-ffa450edef68

          commit c62f2ffa7b9fb026004f66d788ebf1e293d2fdf8
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-26T23:43:29Z

          ZOOKEEPER-1653. zookeeper fails to start because of inconsistent epoch (michim via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1545883 13f79535-47bb-0310-9956-ffa450edef68

          commit 605c8d1b0db0baa57582bb39229c80bfec832ae3
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-11-27T23:23:11Z

          ZOOKEEPER-1821. very ugly warning when compiling load_gen.c (german blanco via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1546231 13f79535-47bb-0310-9956-ffa450edef68

          commit a1cdea63de42ed1eaba224570ad0304c224b21c1
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-04T04:20:53Z

          ZOOKEEPER-1632. fix memory leaks in cli_st (fpj via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1547703 13f79535-47bb-0310-9956-ffa450edef68

          commit f23b85bde1bf53b284a85a8ec6c6251cd63e9feb
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-07T10:17:54Z

          ZOOKEEPER-1459. Standalone ZooKeeperServer is not closing
          the transaction log files on shutdown (Rakesh R via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1548826 13f79535-47bb-0310-9956-ffa450edef68

          commit 4822626f958742baf98303fd9cdfcb51ce95cb46
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-10T20:43:22Z

          ZOOKEEPER-1019. zkfuse doesn't list dependency on boost in README (Raul Gutierrez Segales via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1549963 13f79535-47bb-0310-9956-ffa450edef68

          commit b666d3bccc2e8a0851c4b68024a4c3ac2d97713c
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-11T00:12:53Z

          ZOOKEEPER-1834. Catch IOException in FileTxnLog (fpj via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550006 13f79535-47bb-0310-9956-ffa450edef68

          commit 63b1f92102877757815eec5e0866b7a143868e2d
          Author: Camille Fournier <camille@apache.org>
          Date: 2013-12-11T18:31:05Z

          ZOOKEEPER-1382. Zookeeper server holds onto dead/expired session ids in the watch data structures
          (Germán Blanco and Michael Morello via camille)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550220 13f79535-47bb-0310-9956-ffa450edef68

          commit fc22886f0c12c0b28780dc29a10c334d1221d9b9
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-14T08:36:46Z

          ZOOKEEPER-1715. Upgrade netty version (Sean Bridges via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550902 13f79535-47bb-0310-9956-ffa450edef68

          commit ec70dd2c43bc1d780a480487fe4437cb95d01e65
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-14T11:23:24Z

          ZOOKEEPER-1837. Fix JMXEnv checks (potential race conditions) (Germán Blanco via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550923 13f79535-47bb-0310-9956-ffa450edef68

          commit 7e1c76814a267d52c4392c7c181e116b3eb31233
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-16T04:20:40Z

          ZOOKEEPER-1839. Deadlock in NettyServerCnxn (Rakesh R via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551112 13f79535-47bb-0310-9956-ffa450edef68

          commit a6dec3afdae22bafd8e8fd3c56b258b2a3bbabe8
          Author: Patrick D. Hunt <phunt@apache.org>
          Date: 2013-12-16T06:27:56Z

          ZOOKEEPER-1622. session ids will be negative in the year 2022 (Eric Newton via phunt)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551118 13f79535-47bb-0310-9956-ffa450edef68

          commit 5dd0361a5db1e2a5f998344c8abdd0751988eba1
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2013-12-16T21:49:50Z

          ZOOKEEPER-1756. zookeeper_interest() in C client can return a timeval of 0 (Eric Lindvall via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551367 13f79535-47bb-0310-9956-ffa450edef68

          commit 6c483a2d67d4aee937e0f4873e4b410b7008e703
          Author: Patrick D. Hunt <phunt@apache.org>
          Date: 2013-12-17T16:57:03Z

          ZOOKEEPER-1388. Client side 'PathValidation' is missing for the multi-transaction api. (Rakesh R via marshallm, phunt)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551625 13f79535-47bb-0310-9956-ffa450edef68

          commit 54eefdb4fc57e18f28bbb520e4abb163de2f936a
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-18T13:05:31Z

          ZOOKEEPER-1841. problem in QuorumTest (Germán via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551930 13f79535-47bb-0310-9956-ffa450edef68

          commit 5420ead4bb71dfa83f09c4cce72fa72e649eac62
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-18T15:48:19Z

          ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes
          (michim via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551985 13f79535-47bb-0310-9956-ffa450edef68

          commit 058185d6359393e3898acd745f341f1799b276ce
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-18T15:52:16Z

          ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes
          (michim, Jeffrey Zhong via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551987 13f79535-47bb-0310-9956-ffa450edef68

          commit 7b272f5d5e4d1c170bc72c9b79a462517c06d6d4
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-19T22:36:08Z

          ZOOKEEPER-1849. Need to properly tear down tests in various
          cases (Germán via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552447 13f79535-47bb-0310-9956-ffa450edef68

          commit 05bc123a83d0e355f703001c78b3a54988c678e4
          Author: Patrick D. Hunt <phunt@apache.org>
          Date: 2013-12-20T01:29:22Z

          ZOOKEEPER-1430. add maven deploy support to the build (Giridharan Kesavan via phunt)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552470 13f79535-47bb-0310-9956-ffa450edef68

          commit 7fc3de3a05c9ace88b0e6b914750b2712f43f7c0
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-27T13:29:08Z

          ZOOKEEPER-1179. NettyServerCnxn does not properly close
          socket on 4 letter word requests (Rakesh R, Germán Blanco
          via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553672 13f79535-47bb-0310-9956-ffa450edef68

          commit 80ef32504a46387e051ca9b58e1b5b58b387b358
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2013-12-27T16:50:46Z

          ZOOKEEPER-1179. NettyServerCnxn does not properly close socket on 4 letter word requests. (Rakesh R, Germán Blanco via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553694 13f79535-47bb-0310-9956-ffa450edef68

          commit 68a0f7315d59f4a8090b3a08bb8dab8453bb2fe9
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2014-01-03T00:23:23Z

          ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554979 13f79535-47bb-0310-9956-ffa450edef68

          commit 89448077733a8d025734b79346e403cbcdaa9cea
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2014-01-03T00:44:27Z

          ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554983 13f79535-47bb-0310-9956-ffa450edef68

          commit ca8d611d2db1234bfc0a3f64f2a2a8a15021c8a3
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2014-01-09T19:22:57Z

          ZOOKEEPER-1414. QuorumPeerMainTest.testQuorum, testBadPackets are failing intermittently (Rakesh R via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556926 13f79535-47bb-0310-9956-ffa450edef68

          commit a6528185040b0f782c3d59650b694cf478e01b6a
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2014-01-09T21:03:16Z

          ZOOKEEPER-1057. zookeeper c-client, connection to offline server fails to successfully fallback to second zk host (Germán Blanco via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556949 13f79535-47bb-0310-9956-ffa450edef68

          commit 19e4b850e48cbe8f100ab23cada9f2ea0a05d2be
          Author: Michi Mutsuzaki <michim@apache.org>
          Date: 2014-01-09T23:01:19Z

          ZOOKEEPER-1857. PrepRequestProcessotTest doesn't shutdown ZooKeeper server (Germán Blanco via michim)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556977 13f79535-47bb-0310-9956-ffa450edef68

          commit 9436a70a24d62d38afea2692d2413bd935981b83
          Author: Flavio Paiva Junqueira <fpj@apache.org>
          Date: 2014-01-12T21:36:17Z

          ZOOKEEPER-1238. when the linger time was changed for NIO the patch missed
          Netty (Skye Wanderman-Milne via fpj)

          git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1557614 13f79535-47bb-0310-9956-ffa450edef68


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/369 ZOOKEEPER-2814 : Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 commit 6503f12e144bc6b0652f7adf558bdc28c984e6c0 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-15T18:12:07Z ZOOKEEPER-1786 . ZooKeeper data model documentation is incorrect (Niraj Tolia via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542356 13f79535-47bb-0310-9956-ffa450edef68 commit a452d791cff92d65937142c3475a9894264376f6 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-16T10:06:19Z ZOOKEEPER-1808 . Add version to FLE notifications for 3.4 branch (fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542489 13f79535-47bb-0310-9956-ffa450edef68 commit b770aeb0c8bcb28a9b653b1dc0edac623c75b509 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-17T11:42:22Z ZOOKEEPER-1597 . Windows build failing (michim via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542710 13f79535-47bb-0310-9956-ffa450edef68 commit 7f069c0e084a74f6de661267b828ff3fde30bd11 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-23T18:21:38Z ZOOKEEPER-1817 . Fix don't care for b3.4 (fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1544858 13f79535-47bb-0310-9956-ffa450edef68 commit c62f2ffa7b9fb026004f66d788ebf1e293d2fdf8 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-26T23:43:29Z ZOOKEEPER-1653 . zookeeper fails to start because of inconsistent epoch (michim via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1545883 13f79535-47bb-0310-9956-ffa450edef68 commit 605c8d1b0db0baa57582bb39229c80bfec832ae3 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-11-27T23:23:11Z ZOOKEEPER-1821 . very ugly warning when compiling load_gen.c (german blanco via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1546231 13f79535-47bb-0310-9956-ffa450edef68 commit a1cdea63de42ed1eaba224570ad0304c224b21c1 Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-04T04:20:53Z ZOOKEEPER-1632 . fix memory leaks in cli_st (fpj via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1547703 13f79535-47bb-0310-9956-ffa450edef68 commit f23b85bde1bf53b284a85a8ec6c6251cd63e9feb Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-07T10:17:54Z ZOOKEEPER-1459 . Standalone ZooKeeperServer is not closing the transaction log files on shutdown (Rakesh R via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1548826 13f79535-47bb-0310-9956-ffa450edef68 commit 4822626f958742baf98303fd9cdfcb51ce95cb46 Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-10T20:43:22Z ZOOKEEPER-1019 . zkfuse doesn't list dependency on boost in README (Raul Gutierrez Segales via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1549963 13f79535-47bb-0310-9956-ffa450edef68 commit b666d3bccc2e8a0851c4b68024a4c3ac2d97713c Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-11T00:12:53Z ZOOKEEPER-1834 . Catch IOException in FileTxnLog (fpj via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550006 13f79535-47bb-0310-9956-ffa450edef68 commit 63b1f92102877757815eec5e0866b7a143868e2d Author: Camille Fournier <camille@apache.org> Date: 2013-12-11T18:31:05Z ZOOKEEPER-1382 . Zookeeper server holds onto dead/expired session ids in the watch data structures (Germán Blanco and Michael Morello via camille) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550220 13f79535-47bb-0310-9956-ffa450edef68 commit fc22886f0c12c0b28780dc29a10c334d1221d9b9 Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-14T08:36:46Z ZOOKEEPER-1715 . Upgrade netty version (Sean Bridges via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550902 13f79535-47bb-0310-9956-ffa450edef68 commit ec70dd2c43bc1d780a480487fe4437cb95d01e65 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-14T11:23:24Z ZOOKEEPER-1837 . Fix JMXEnv checks (potential race conditions) (Germán Blanco via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550923 13f79535-47bb-0310-9956-ffa450edef68 commit 7e1c76814a267d52c4392c7c181e116b3eb31233 Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-16T04:20:40Z ZOOKEEPER-1839 . Deadlock in NettyServerCnxn (Rakesh R via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551112 13f79535-47bb-0310-9956-ffa450edef68 commit a6dec3afdae22bafd8e8fd3c56b258b2a3bbabe8 Author: Patrick D. Hunt <phunt@apache.org> Date: 2013-12-16T06:27:56Z ZOOKEEPER-1622 . session ids will be negative in the year 2022 (Eric Newton via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551118 13f79535-47bb-0310-9956-ffa450edef68 commit 5dd0361a5db1e2a5f998344c8abdd0751988eba1 Author: Michi Mutsuzaki <michim@apache.org> Date: 2013-12-16T21:49:50Z ZOOKEEPER-1756 . zookeeper_interest() in C client can return a timeval of 0 (Eric Lindvall via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551367 13f79535-47bb-0310-9956-ffa450edef68 commit 6c483a2d67d4aee937e0f4873e4b410b7008e703 Author: Patrick D. Hunt <phunt@apache.org> Date: 2013-12-17T16:57:03Z ZOOKEEPER-1388 . Client side 'PathValidation' is missing for the multi-transaction api. (Rakesh R via marshallm, phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551625 13f79535-47bb-0310-9956-ffa450edef68 commit 54eefdb4fc57e18f28bbb520e4abb163de2f936a Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-18T13:05:31Z ZOOKEEPER-1841 . problem in QuorumTest (Germán via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551930 13f79535-47bb-0310-9956-ffa450edef68 commit 5420ead4bb71dfa83f09c4cce72fa72e649eac62 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-18T15:48:19Z ZOOKEEPER-1733 . FLETest#testLE is flaky on windows boxes (michim via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551985 13f79535-47bb-0310-9956-ffa450edef68 commit 058185d6359393e3898acd745f341f1799b276ce Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-18T15:52:16Z ZOOKEEPER-1733 . FLETest#testLE is flaky on windows boxes (michim, Jeffrey Zhong via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551987 13f79535-47bb-0310-9956-ffa450edef68 commit 7b272f5d5e4d1c170bc72c9b79a462517c06d6d4 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-19T22:36:08Z ZOOKEEPER-1849 . Need to properly tear down tests in various cases (Germán via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552447 13f79535-47bb-0310-9956-ffa450edef68 commit 05bc123a83d0e355f703001c78b3a54988c678e4 Author: Patrick D. Hunt <phunt@apache.org> Date: 2013-12-20T01:29:22Z ZOOKEEPER-1430 . add maven deploy support to the build (Giridharan Kesavan via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552470 13f79535-47bb-0310-9956-ffa450edef68 commit 7fc3de3a05c9ace88b0e6b914750b2712f43f7c0 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-27T13:29:08Z ZOOKEEPER-1179 . NettyServerCnxn does not properly close socket on 4 letter word requests (Rakesh R, Germán Blanco via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553672 13f79535-47bb-0310-9956-ffa450edef68 commit 80ef32504a46387e051ca9b58e1b5b58b387b358 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2013-12-27T16:50:46Z ZOOKEEPER-1179 . NettyServerCnxn does not properly close socket on 4 letter word requests. (Rakesh R, Germán Blanco via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553694 13f79535-47bb-0310-9956-ffa450edef68 commit 68a0f7315d59f4a8090b3a08bb8dab8453bb2fe9 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2014-01-03T00:23:23Z ZOOKEEPER-1852 . ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554979 13f79535-47bb-0310-9956-ffa450edef68 commit 89448077733a8d025734b79346e403cbcdaa9cea Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2014-01-03T00:44:27Z ZOOKEEPER-1852 . ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554983 13f79535-47bb-0310-9956-ffa450edef68 commit ca8d611d2db1234bfc0a3f64f2a2a8a15021c8a3 Author: Michi Mutsuzaki <michim@apache.org> Date: 2014-01-09T19:22:57Z ZOOKEEPER-1414 . QuorumPeerMainTest.testQuorum, testBadPackets are failing intermittently (Rakesh R via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556926 13f79535-47bb-0310-9956-ffa450edef68 commit a6528185040b0f782c3d59650b694cf478e01b6a Author: Michi Mutsuzaki <michim@apache.org> Date: 2014-01-09T21:03:16Z ZOOKEEPER-1057 . zookeeper c-client, connection to offline server fails to successfully fallback to second zk host (Germán Blanco via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556949 13f79535-47bb-0310-9956-ffa450edef68 commit 19e4b850e48cbe8f100ab23cada9f2ea0a05d2be Author: Michi Mutsuzaki <michim@apache.org> Date: 2014-01-09T23:01:19Z ZOOKEEPER-1857 . PrepRequestProcessotTest doesn't shutdown ZooKeeper server (Germán Blanco via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556977 13f79535-47bb-0310-9956-ffa450edef68 commit 9436a70a24d62d38afea2692d2413bd935981b83 Author: Flavio Paiva Junqueira <fpj@apache.org> Date: 2014-01-12T21:36:17Z ZOOKEEPER-1238 . when the linger time was changed for NIO the patch missed Netty (Skye Wanderman-Milne via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1557614 13f79535-47bb-0310-9956-ffa450edef68
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide closed the pull request at:

          https://github.com/apache/zookeeper/pull/369

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide closed the pull request at: https://github.com/apache/zookeeper/pull/369
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide opened a pull request:

          https://github.com/apache/zookeeper/pull/370

          Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

          Ported ZOOKEEPER-2814 from master to branch 3.4.

          Added files
          src/java/main/org/apache/zookeeper/common/StringUtils.java
          src/java/test/org/apache/zookeeper/test/StringUtilTest.java

          Modified Files:
          src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
          src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/370.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #370


          commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:14:29Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space after comma in connection string
          Port ZOOKEEPER-2814 from master

          commit 3f210394e989507282d1e42fb9f3e35512d314e8
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:19:44Z

          Zookeeper 2814: ignore space after comma in connection string

          Port Zookeeper 2814 from master to branch - 3.4
          Created StringUtils.java

          commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:22:26Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added code to test split logic implemented in StringUtils.java

          commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:26:08Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added test to verify the logic added to remove the spaces provided in connection string

          commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T15:15:34Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Ported ZOOKEEPER-2814 from master to 3.4

          commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T15:16:58Z

          ZOOKEEPER-2814: Ignore space after comma in connection string


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/370 Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:14:29Z ZOOKEEPER-2814 : Ignore space after comma in connection string Added logic to trim host connection string for ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master commit 3f210394e989507282d1e42fb9f3e35512d314e8 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:19:44Z Zookeeper 2814: ignore space after comma in connection string Port Zookeeper 2814 from master to branch - 3.4 Created StringUtils.java commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:22:26Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added code to test split logic implemented in StringUtils.java commit 1629f64f58c7787bb993162e5c9b8565b4d45c64 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:26:08Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added test to verify the logic added to remove the spaces provided in connection string commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T15:15:34Z ZOOKEEPER-2814 : Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to 3.4 commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T15:16:58Z ZOOKEEPER-2814 : Ignore space after comma in connection string
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilbhide closed the pull request at:

          https://github.com/apache/zookeeper/pull/370

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilbhide closed the pull request at: https://github.com/apache/zookeeper/pull/370
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nikhilbhide opened a pull request:

          https://github.com/apache/zookeeper/pull/371

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Ported ZOOKEEPER-2814 from master to branch 3.4.

          Added files
          src/java/main/org/apache/zookeeper/common/StringUtils.java
          src/java/test/org/apache/zookeeper/test/StringUtilTest.java

          Modified Files:
          src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
          src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/371.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #371


          commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:14:29Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space after comma in connection string
          Port ZOOKEEPER-2814 from master

          commit 3f210394e989507282d1e42fb9f3e35512d314e8
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:19:44Z

          Zookeeper 2814: ignore space after comma in connection string

          Port Zookeeper 2814 from master to branch - 3.4
          Created StringUtils.java

          commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:22:26Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added code to test split logic implemented in StringUtils.java

          commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T13:26:08Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Port ZOOKEEPER-2814 from master to branch-3.4
          Added test to verify the logic added to remove the spaces provided in connection string

          commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T15:15:34Z

          ZOOKEEPER-2814: Ignore space after comma in connection string

          Ported ZOOKEEPER-2814 from master to 3.4

          commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2
          Author: Nikhil Bhide <nikhilbhide15@gmail.com>
          Date: 2017-09-11T15:16:58Z

          ZOOKEEPER-2814: Ignore space after comma in connection string


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/371 ZOOKEEPER-2814 : Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to branch 3.4. Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:14:29Z ZOOKEEPER-2814 : Ignore space after comma in connection string Added logic to trim host connection string for ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master commit 3f210394e989507282d1e42fb9f3e35512d314e8 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:19:44Z Zookeeper 2814: ignore space after comma in connection string Port Zookeeper 2814 from master to branch - 3.4 Created StringUtils.java commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:22:26Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added code to test split logic implemented in StringUtils.java commit 1629f64f58c7787bb993162e5c9b8565b4d45c64 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T13:26:08Z ZOOKEEPER-2814 : Ignore space after comma in connection string Port ZOOKEEPER-2814 from master to branch-3.4 Added test to verify the logic added to remove the spaces provided in connection string commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T15:15:34Z ZOOKEEPER-2814 : Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to 3.4 commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2 Author: Nikhil Bhide <nikhilbhide15@gmail.com> Date: 2017-09-11T15:16:58Z ZOOKEEPER-2814 : Ignore space after comma in connection string
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//console This message is automatically generated.

            People

            • Assignee:
              nikbhi15 Nikhil Bhide
              Reporter:
              vilo Viliam Durina
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development