[ZOOKEEPER-2767] Correct the exception messages in X509Util if truststore location or password is not configured

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.5.4, 3.6.0
• Fix Version/s: 3.5.4, 3.6.0
• Component/s: java client, server
• Assignee: Abhishek Kumar
• Reporter: Abhishek Kumar
• Created: 27/Apr/17 12:14
• Updated: 13/Jul/17 02:59
• Resolved: 26/May/17 23:04

Description

In org.apache.zookeeper.common.X509Util.org.apache.zookeeper.common.X509Util.createSSLContext exception messages contains keystore related messages instead of truststore messages for truststore location/password checks:

if (trustStoreLocationProp == null && trustStorePasswordProp == null) {
            LOG.warn("keystore not specified for client connection");
        } else {
            if (trustStoreLocationProp == null) {
                throw new SSLContextException("keystore location not specified for client connection");
            }
            if (trustStorePasswordProp == null) {
                throw new SSLContextException("keystore password not specified for client connection");
            }
            try {
                trustManagers = new TrustManager[]{
                        createTrustManager(trustStoreLocationProp, trustStorePasswordProp)};
            } catch (TrustManagerException e) {
                throw new SSLContextException("Failed to create KeyManager", e);
            }
        }

Issue Links

• links to: GitHub Pull Request #246
• links to: GitHub Pull Request #263