[ZOOKEEPER-2729] Cleanup findbug warnings in branch-3.4: Correctness Warnings

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.9
• Fix Version/s: 3.4.11
• Assignee: Abraham Fine
• Reporter: Rakesh Radhakrishnan
• Created: 20/Mar/17 05:16
• Updated: 13/Apr/17 16:57
• Resolved: 08/Apr/17 22:31

Description

(1) INT Bad comparison of nonnegative value with 0 in org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, byte[])
Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details) 
In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner
In method org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, byte[])
Value 0
At SaslQuorumAuthLearner.java:[line 176]

(2) INT	Bad comparison of nonnegative value with 0 in org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream, byte[], QuorumAuth$Status)
Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details) 
In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer
In method org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream, byte[], QuorumAuth$Status)
Value 0
At SaslQuorumAuthServer.java:[line 170]

Issue Links

• links to: GitHub Pull Request #220