Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2719

Port ZOOKEEPER-2169 (TTL Nodes) to 3.5 branch

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.3
    • Component/s: java client, server
    • Labels:
      None

      Description

      ZOOKEEPER-2169 is a useful feature that should be deployed sooner than later. Take the work done in the master branch and port it to the 3.5 branch

        Issue Links

          Activity

          Hide
          randgalt Jordan Zimmerman added a comment -

          NOTE: this will also include ZOOKEEPER-2608

          Show
          randgalt Jordan Zimmerman added a comment - NOTE: this will also include ZOOKEEPER-2608
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Randgalt opened a pull request:

          https://github.com/apache/zookeeper/pull/192

          ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 branch

          This PR cherry-picks changes for TTL nodes (ZOOKEEPER-2169) and the CLI for it (ZOOKEEPER-2608) into branch-3.5.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2719

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/192.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #192


          commit 66fdccbc115a7080225431da87a8b3e34453d854
          Author: randgalt <jordan@jordanzimmerman.com>
          Date: 2016-09-28T08:32:50Z

          This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already.
          In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning.
          New opcodes and transaction records had to be added in a similar manner to Containers

          NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link:
          https://reviews.apache.org/r/46983/#comment214810

          commit 64f77a518d9c9608375cf06855439d8c06928fb1
          Author: randgalt <jordan@jordanzimmerman.com>
          Date: 2017-03-14T19:07:36Z

          cleaned up some doc merge issues

          commit 39b969b3fb753f41e8f981d4d726e02853320cc7
          Author: randgalt <jordan@jordanzimmerman.com>
          Date: 2016-10-09T10:23:38Z

          Removed bogus import

          commit 6343001d89c132c9b4fa7ee8b035acf40bd18f21
          Author: randgalt <jordan@jordanzimmerman.com>
          Date: 2016-10-09T10:43:41Z

          Added ttl option to CLI create command


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/192 ZOOKEEPER-2719 : Pull changes for TTL Nodes into 3.5 branch This PR cherry-picks changes for TTL nodes ( ZOOKEEPER-2169 ) and the CLI for it ( ZOOKEEPER-2608 ) into branch-3.5. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2719 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 66fdccbc115a7080225431da87a8b3e34453d854 Author: randgalt <jordan@jordanzimmerman.com> Date: 2016-09-28T08:32:50Z This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already. In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning. New opcodes and transaction records had to be added in a similar manner to Containers NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link: https://reviews.apache.org/r/46983/#comment214810 commit 64f77a518d9c9608375cf06855439d8c06928fb1 Author: randgalt <jordan@jordanzimmerman.com> Date: 2017-03-14T19:07:36Z cleaned up some doc merge issues commit 39b969b3fb753f41e8f981d4d726e02853320cc7 Author: randgalt <jordan@jordanzimmerman.com> Date: 2016-10-09T10:23:38Z Removed bogus import commit 6343001d89c132c9b4fa7ee8b035acf40bd18f21 Author: randgalt <jordan@jordanzimmerman.com> Date: 2016-10-09T10:43:41Z Added ttl option to CLI create command
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 0 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/418//console This message is automatically generated.
          Hide
          randgalt Jordan Zimmerman added a comment -

          The release audit problems seem to be a Jenkins issue and not related to this patch:

          [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
          [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
          Lines that start with ????? in the release audit report indicate files that do not have an Apache license header.
          
          Show
          randgalt Jordan Zimmerman added a comment - The release audit problems seem to be a Jenkins issue and not related to this patch: [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer Lines that start with ????? in the release audit report indicate files that do not have an Apache license header.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hanm commented on the issue:

          https://github.com/apache/zookeeper/pull/192

          LGTM. I did some testing using CLI and it works as expected.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/192 LGTM. I did some testing using CLI and it works as expected.
          Hide
          fournc Camille Fournier added a comment -

          Issue resolved by pull request 192
          https://github.com/apache/zookeeper/pull/192

          Show
          fournc Camille Fournier added a comment - Issue resolved by pull request 192 https://github.com/apache/zookeeper/pull/192
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eribeiro commented on the issue:

          https://github.com/apache/zookeeper/pull/192

          Hi @Randgalt, congrats on getting this PR ported to 3.5! :smiley: Please, could you close this PR as it has been merged? Best regards!

          Show
          githubbot ASF GitHub Bot added a comment - Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/192 Hi @Randgalt, congrats on getting this PR ported to 3.5! :smiley: Please, could you close this PR as it has been merged? Best regards!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Randgalt commented on the issue:

          https://github.com/apache/zookeeper/pull/192

          merged into `branch-3.5`

          Show
          githubbot ASF GitHub Bot added a comment - Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/192 merged into `branch-3.5`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Randgalt closed the pull request at:

          https://github.com/apache/zookeeper/pull/192

          Show
          githubbot ASF GitHub Bot added a comment - Github user Randgalt closed the pull request at: https://github.com/apache/zookeeper/pull/192

            People

            • Assignee:
              randgalt Jordan Zimmerman
              Reporter:
              randgalt Jordan Zimmerman
            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development