ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-271

Better command line parsing in ZookeeperMain.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 3.0.1
    • Fix Version/s: 3.5.0
    • Component/s: java client
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      There are three incompatibilities introduced by this commit into the client shell:

      1) now requires commons-cli
      2) get no longer returns stat information by default, however there is a "-s" option that will result in the stat being included
      3) a deprecated message is reported in some cases, when the old command format is used. As a result the output of the command may be different compared to client output prior to this change.
      Show
      There are three incompatibilities introduced by this commit into the client shell: 1) now requires commons-cli 2) get no longer returns stat information by default, however there is a "-s" option that will result in the stat being included 3) a deprecated message is reported in some cases, when the old command format is used. As a result the output of the command may be different compared to client output prior to this change.

      Description

      The command line parsing in zookeepermain is very basic.We should use some kind of cli parsing (commons-cli?) or something else that is standard and improve our command line parsing. This will remove the scattered code that we have in zookeepermain and we will have much better command line parsing.

      1. ZOOKEEPER-271.patch
        77 kB
        Hartmut Lang
      2. ZOOKEEPER-271-1.patch
        77 kB
        Hartmut Lang

        Issue Links

          Activity

          Mahadev konar created issue -
          Patrick Hunt made changes -
          Field Original Value New Value
          Fix Version/s 3.3.0 [ 12313976 ]
          Fix Version/s 3.2.0 [ 12313491 ]
          Patrick Hunt made changes -
          Fix Version/s 3.4.0 [ 12314469 ]
          Fix Version/s 3.3.0 [ 12313976 ]
          Mahadev konar made changes -
          Fix Version/s 3.5.0 [ 12316644 ]
          Fix Version/s 3.4.0 [ 12314469 ]
          Hartmut Lang made changes -
          Attachment ZOOKEEPER-271-1.patch [ 12517001 ]
          Camille Fournier made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Patrick Hunt made changes -
          Assignee Hartmut Lang [ hlang ]
          Hartmut Lang made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Hartmut Lang made changes -
          Attachment ZOOKEEPER-271.patch [ 12517198 ]
          Hartmut Lang made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Hartmut Lang made changes -
          Link This issue blocks ZOOKEEPER-1408 [ ZOOKEEPER-1408 ]
          Hartmut Lang made changes -
          Link This issue blocks ZOOKEEPER-1409 [ ZOOKEEPER-1409 ]
          Hartmut Lang made changes -
          Link This issue supercedes ZOOKEEPER-1307 [ ZOOKEEPER-1307 ]
          Patrick Hunt made changes -
          Hadoop Flags Incompatible change,Reviewed [ 10342,10343 ]
          Release Note There are three incompatibilities introduced by this commit into the client shell:

          1) now requires commons-cli
          2) get no longer returns stat information by default, however there is a "-s" option that will result in the stat being included
          3) a deprecated message is reported in some cases, when the old command format is used. As a result the output of the command may be different compared to client output prior to this change.
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Link This issue blocks ZOOKEEPER-1408 [ ZOOKEEPER-1408 ]
          Gavin made changes -
          Link This issue is depended upon by ZOOKEEPER-1408 [ ZOOKEEPER-1408 ]
          Gavin made changes -
          Link This issue blocks ZOOKEEPER-1409 [ ZOOKEEPER-1409 ]
          Gavin made changes -
          Link This issue is depended upon by ZOOKEEPER-1409 [ ZOOKEEPER-1409 ]

            People

            • Assignee:
              Hartmut Lang
              Reporter:
              Mahadev konar
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development