Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2630

Use interface type instead of implementation type when appropriate.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6.0
    • Component/s: None

      Description

      There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice.

      See more info on https://github.com/apache/zookeeper/pull/102

        Issue Links

          Activity

          Hide
          panchaks Umesh Panchaksharaiah added a comment -

          Hi, If no one is working on this, I will pick this up. Thanks

          Show
          panchaks Umesh Panchaksharaiah added a comment - Hi, If no one is working on this, I will pick this up. Thanks
          Hide
          panchaks Umesh Panchaksharaiah added a comment -

          Hi Michael,

          How did you find all the instances for replacements? One way is the brute
          force method of looking at each declaration of HashMap / HashSet and see if
          the usage is confined to Map / Set interface methods. Is there a more efficient
          way to find all the instances of replacement using perhaps Eclipse? (An Eclipse
          newbie and hence the question?). Thank you. -Umesh

          Show
          panchaks Umesh Panchaksharaiah added a comment - Hi Michael, How did you find all the instances for replacements? One way is the brute force method of looking at each declaration of HashMap / HashSet and see if the usage is confined to Map / Set interface methods. Is there a more efficient way to find all the instances of replacement using perhaps Eclipse? (An Eclipse newbie and hence the question?). Thank you. -Umesh
          Hide
          hanm Michael Han added a comment -

          I don't think there is a sublinear algorithm because you have to check every declaration and replace if needed - using IDE might help but a grep on code base should also work, and there should not be too many set/map declarations in this case.

          Show
          hanm Michael Han added a comment - I don't think there is a sublinear algorithm because you have to check every declaration and replace if needed - using IDE might help but a grep on code base should also work, and there should not be too many set/map declarations in this case.
          Hide
          panchaks Umesh Panchaksharaiah added a comment -

          Got it. I just wanted to make sure there is no hidden IDE magic

          Show
          panchaks Umesh Panchaksharaiah added a comment - Got it. I just wanted to make sure there is no hidden IDE magic
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tamaashu opened a pull request:

          https://github.com/apache/zookeeper/pull/354

          ZOOKEEPER-2630: Use interface type instead of implementation type whe…

          Use interface type instead of implementation type when appropriate.

          There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice.

          Checked and fixed Set, Map and List interface usages.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-2630

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zookeeper/pull/354.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #354


          commit c9ab1da4cfc8bc30e3a93df08e0d865532f9fb40
          Author: Tamas Penzes <tamaas@cloudera.com>
          Date: 2017-08-31T15:10:33Z

          ZOOKEEPER-2630: Use interface type instead of implementation type when appropriate.

          Checked and fixed Set, Map and List interface usages.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tamaashu opened a pull request: https://github.com/apache/zookeeper/pull/354 ZOOKEEPER-2630 : Use interface type instead of implementation type whe… Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-2630 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #354 commit c9ab1da4cfc8bc30e3a93df08e0d865532f9fb40 Author: Tamas Penzes <tamaas@cloudera.com> Date: 2017-08-31T15:10:33Z ZOOKEEPER-2630 : Use interface type instead of implementation type when appropriate. Checked and fixed Set, Map and List interface usages.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 74 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 74 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/984//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user afine commented on a diff in the pull request:

          https://github.com/apache/zookeeper/pull/354#discussion_r136431051

          — Diff: src/java/main/org/apache/jute/compiler/JRecord.java —
          @@ -21,9 +21,7 @@
          import java.io.File;
          import java.io.FileWriter;
          import java.io.IOException;
          -import java.util.ArrayList;
          -import java.util.HashMap;
          -import java.util.Iterator;
          +import java.util.*;
          — End diff –

          we generally avoid using * inputs

          Show
          githubbot ASF GitHub Bot added a comment - Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/354#discussion_r136431051 — Diff: src/java/main/org/apache/jute/compiler/JRecord.java — @@ -21,9 +21,7 @@ import java.io.File; import java.io.FileWriter; import java.io.IOException; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.Iterator; +import java.util.*; — End diff – we generally avoid using * inputs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tamaashu commented on a diff in the pull request:

          https://github.com/apache/zookeeper/pull/354#discussion_r136557551

          — Diff: src/java/main/org/apache/jute/compiler/JRecord.java —
          @@ -21,9 +21,7 @@
          import java.io.File;
          import java.io.FileWriter;
          import java.io.IOException;
          -import java.util.ArrayList;
          -import java.util.HashMap;
          -import java.util.Iterator;
          +import java.util.*;
          — End diff –

          working on the fix in my next commit

          Show
          githubbot ASF GitHub Bot added a comment - Github user tamaashu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/354#discussion_r136557551 — Diff: src/java/main/org/apache/jute/compiler/JRecord.java — @@ -21,9 +21,7 @@ import java.io.File; import java.io.FileWriter; import java.io.IOException; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.Iterator; +import java.util.*; — End diff – working on the fix in my next commit
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tamaashu commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          fixed the issues with the imports

          Show
          githubbot ASF GitHub Bot added a comment - Github user tamaashu commented on the issue: https://github.com/apache/zookeeper/pull/354 fixed the issues with the imports
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. GitHub Pull Request Build

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 74 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 74 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/989//console This message is automatically generated.
          Hide
          hanm Michael Han added a comment -

          Issue resolved by pull request 354
          https://github.com/apache/zookeeper/pull/354

          Show
          hanm Michael Han added a comment - Issue resolved by pull request 354 https://github.com/apache/zookeeper/pull/354
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zookeeper/pull/354

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/354
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hanm commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          Committed to master: 1165794be9587acccc02782dbff95bc482222528.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 Committed to master: 1165794be9587acccc02782dbff95bc482222528.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hanm commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          @tamaashu This patch does not apply to branch-3.4 and branch-3.5. For now it's only applied on master and I resolved the JIRA with a target version of 3.6. If you'd like this land on 3.4 and 3.5, please create separate pull requests.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 @tamaashu This patch does not apply to branch-3.4 and branch-3.5. For now it's only applied on master and I resolved the JIRA with a target version of 3.6. If you'd like this land on 3.4 and 3.5, please create separate pull requests.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eribeiro commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          Late to the party but awesome work! Congrats! :+1:

          @hanm are those changes applied to both master and branch-3.5? No branch-4.5 backport, right?

          Show
          githubbot ASF GitHub Bot added a comment - Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/354 Late to the party but awesome work! Congrats! :+1: @hanm are those changes applied to both master and branch-3.5? No branch-4.5 backport, right?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3531 (See https://builds.apache.org/job/ZooKeeper-trunk/3531/)
          ZOOKEEPER-2630: Use interface type instead of implementation type whe… (hanm: rev 1165794be9587acccc02782dbff95bc482222528)

          • (edit) src/java/test/org/apache/zookeeper/test/ACLTest.java
          • (edit) src/java/test/org/apache/zookeeper/test/SessionTest.java
          • (edit) docs/zookeeperReconfig.html
          • (edit) src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java
          • (edit) src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
          • (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/servlets/Throughput.java
          • (edit) src/java/main/org/apache/zookeeper/server/DataTree.java
          • (edit) src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorConnectionPropertiesDialog.java
          • (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java
          • (edit) src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
          • (edit) src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java
          • (edit) src/java/main/org/apache/jute/compiler/JFile.java
          • (edit) src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
          • (edit) src/java/main/org/apache/zookeeper/server/quorum/Leader.java
          • (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/FilterOp.java
          • (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java
          • (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/LogEntry.java
          • (edit) src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
          • (edit) src/recipes/queue/src/java/org/apache/zookeeper/recipes/queue/DistributedQueue.java
          • (edit) src/java/test/org/apache/zookeeper/test/FLETest.java
          • (edit) src/java/test/org/apache/zookeeper/test/QuorumBase.java
          • (edit) src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
          • (edit) src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorPanel.java
          • (edit) src/java/main/org/apache/jute/compiler/JRecord.java
          • (edit) src/java/test/org/apache/zookeeper/test/FLERestartTest.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
          • (edit) src/java/test/org/apache/zookeeper/test/IntegrityCheck.java
          • (edit) src/java/test/org/apache/zookeeper/test/AsyncTest.java
          • (edit) src/java/test/org/apache/zookeeper/test/TruncateTest.java
          • (edit) src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
          • (edit) src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java
          • (edit) src/java/main/org/apache/jute/compiler/CSharpGenerator.java
          • (edit) src/java/main/org/apache/jute/compiler/JavaGenerator.java
          • (edit) src/java/main/org/apache/zookeeper/Environment.java
          • (edit) src/java/main/org/apache/jute/compiler/CGenerator.java
          • (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
          • (edit) src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml
          • (edit) src/java/main/org/apache/zookeeper/common/PathTrie.java
          • (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/MeasureThroughput.java
          • (edit) src/contrib/fatjar/src/java/org/apache/zookeeper/util/FatJarMain.java
          • (edit) src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java
          • (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
          • (edit) src/java/main/org/apache/zookeeper/server/WatchManager.java
          • (edit) src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
          • (edit) src/java/test/org/apache/zookeeper/test/OOMTest.java
          • (edit) src/java/test/org/apache/zookeeper/test/ReconfigTest.java
          • (edit) src/java/test/org/apache/zookeeper/server/quorum/QuorumRequestPipelineTest.java
          • (edit) src/java/main/org/apache/jute/compiler/CppGenerator.java
          • (edit) src/java/test/org/apache/zookeeper/test/LocalSessionsOnlyTest.java
          • (edit) src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3531 (See https://builds.apache.org/job/ZooKeeper-trunk/3531/ ) ZOOKEEPER-2630 : Use interface type instead of implementation type whe… (hanm: rev 1165794be9587acccc02782dbff95bc482222528) (edit) src/java/test/org/apache/zookeeper/test/ACLTest.java (edit) src/java/test/org/apache/zookeeper/test/SessionTest.java (edit) docs/zookeeperReconfig.html (edit) src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java (edit) src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/servlets/Throughput.java (edit) src/java/main/org/apache/zookeeper/server/DataTree.java (edit) src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorConnectionPropertiesDialog.java (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java (edit) src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java (edit) src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java (edit) src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java (edit) src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java (edit) src/java/main/org/apache/jute/compiler/JFile.java (edit) src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java (edit) src/java/main/org/apache/zookeeper/server/quorum/Leader.java (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/FilterOp.java (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/LogEntry.java (edit) src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java (edit) src/recipes/queue/src/java/org/apache/zookeeper/recipes/queue/DistributedQueue.java (edit) src/java/test/org/apache/zookeeper/test/FLETest.java (edit) src/java/test/org/apache/zookeeper/test/QuorumBase.java (edit) src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java (edit) src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java (edit) src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorPanel.java (edit) src/java/main/org/apache/jute/compiler/JRecord.java (edit) src/java/test/org/apache/zookeeper/test/FLERestartTest.java (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java (edit) src/java/test/org/apache/zookeeper/test/IntegrityCheck.java (edit) src/java/test/org/apache/zookeeper/test/AsyncTest.java (edit) src/java/test/org/apache/zookeeper/test/TruncateTest.java (edit) src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (edit) src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java (edit) src/java/main/org/apache/jute/compiler/CSharpGenerator.java (edit) src/java/main/org/apache/jute/compiler/JavaGenerator.java (edit) src/java/main/org/apache/zookeeper/Environment.java (edit) src/java/main/org/apache/jute/compiler/CGenerator.java (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java (edit) src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml (edit) src/java/main/org/apache/zookeeper/common/PathTrie.java (edit) src/contrib/loggraph/src/java/org/apache/zookeeper/graph/MeasureThroughput.java (edit) src/contrib/fatjar/src/java/org/apache/zookeeper/util/FatJarMain.java (edit) src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java (edit) src/java/main/org/apache/zookeeper/server/WatchManager.java (edit) src/java/test/org/apache/zookeeper/test/CnxManagerTest.java (edit) src/java/test/org/apache/zookeeper/test/OOMTest.java (edit) src/java/test/org/apache/zookeeper/test/ReconfigTest.java (edit) src/java/test/org/apache/zookeeper/server/quorum/QuorumRequestPipelineTest.java (edit) src/java/main/org/apache/jute/compiler/CppGenerator.java (edit) src/java/test/org/apache/zookeeper/test/LocalSessionsOnlyTest.java (edit) src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hanm commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          @eribeiro not sure why you asked - thought I made it clear that the patch for now only applied on master, because this pull request can't apply as is on other branches without some additional work which I don't have time to do myself. That said, if you or anyone else want same change land on other branches, please feel free to propose pull requests.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 @eribeiro not sure why you asked - thought I made it clear that the patch for now only applied on master, because this pull request can't apply as is on other branches without some additional work which I don't have time to do myself. That said, if you or anyone else want same change land on other branches, please feel free to propose pull requests.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eribeiro commented on the issue:

          https://github.com/apache/zookeeper/pull/354

          @hanm oh, totally my fault asking an already answered question. Excuse me. Even tough, I see my (useless) question and your comment were roughly 9 hours ago, and I remember very well the last comment I saw on this thread being "Committed to master: 1165794." (also about 9 hours ago). So, I suppose it was some sort of eventual consistency glitch that prevented me from reading your comment before posting. Whatever, sorry about that.

          @tamaashu Please, let me know if you are planning to work on porting the changes in this PR to branch-3.5 and branch-3.4. If you cannot and don't mind, I can pick up the work of porting the changes in this PR to branch-3.5, at least. Best regards!

          Show
          githubbot ASF GitHub Bot added a comment - Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/354 @hanm oh, totally my fault asking an already answered question. Excuse me. Even tough, I see my (useless) question and your comment were roughly 9 hours ago, and I remember very well the last comment I saw on this thread being "Committed to master: 1165794." (also about 9 hours ago). So, I suppose it was some sort of eventual consistency glitch that prevented me from reading your comment before posting. Whatever, sorry about that. @tamaashu Please, let me know if you are planning to work on porting the changes in this PR to branch-3.5 and branch-3.4. If you cannot and don't mind, I can pick up the work of porting the changes in this PR to branch-3.5, at least. Best regards!

            People

            • Assignee:
              tamaas Tamas Penzes
              Reporter:
              hanm Michael Han
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development