[ZOOKEEPER-2490] infinitely connect on windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.5.2
• Fix Version/s: 3.7.0, 3.6.1, 3.5.8
• Component/s: c client
• Labels: pull-request-available

Environment

Windows

• Assignee: spooky000
• Reporter: spooky000
• Created: 27/Jul/16 06:17
• Updated: 11/May/20 15:41
• Resolved: 14/Apr/20 10:01

Description

in addrvec_contains function
this memcmp always return false on windows release build.

for (i = 0; i < avec->count; i++)
{
if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0)
return 1;
}

because..
#define INET_ADDRSTRLEN 16 on linux.
#define INET_ADDRSTRLEN 22 on windows.

Issue Links

• is fixed by: ZOOKEEPER-3726 invalid ipv6 address comparison in C client
• is related to: ZOOKEEPER-3726 invalid ipv6 address comparison in C client
• links to: GitHub Pull Request #309
• links to: GitHub Pull Request #309