[ZOOKEEPER-2442] Socket leak in QuorumCnxManager connectOne

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.1
• Fix Version/s: 3.5.3, 3.6.0
• Component/s: quorum, server
• Assignee: Michael Han
• Reporter: Michael Han
• Created: 03/Jun/16 23:05
• Updated: 18/May/17 03:43
• Resolved: 03/Aug/16 04:32

Description

The function connectOne() in QuorumCnxManager.java sometimes fails to release a socket allocated by Socket():

 try {

                if (LOG.isDebugEnabled()) {
                    LOG.debug("Opening channel to server " + sid);
                }
                Socket sock = new Socket();
                setSockOpts(sock);
                sock.connect(self.getView().get(sid).electionAddr, cnxTO);
                if (LOG.isDebugEnabled()) {
                    LOG.debug("Connected to server " + sid);
                }
                initiateConnection(sock, sid);
            } catch (UnresolvedAddressException e) {
                // Sun doesn't include the address that causes this
                // exception to be thrown, also UAE cannot be wrapped cleanly
                // so we log the exception in order to capture this critical
                // detail.
                LOG.warn("Cannot open channel to " + sid
                        + " at election address " + electionAddr, e);
                throw e;
            } catch (IOException e) {
                LOG.warn("Cannot open channel to " + sid
                        + " at election address " + electionAddr,
                        e);
            }

Another place in Listener.run() where the client socket is not explicitly closed.