[ZOOKEEPER-2416] Remove Java System property usage from ZooKeeper server code

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: server
• Assignee: Mohammad Arshad
• Reporter: Mohammad Arshad
• Created: 26/Apr/16 08:02
• Updated: 03/Feb/22 08:50

Description

Many ZooKeeper properties are used as Java System properties in the ZooKeeper code.
Some example:

public static int getSnapCount() {
String sc = System.getProperty("zookeeper.snapCount");

public int getGlobalOutstandingLimit() { String sc = 
System.getProperty("zookeeper.globalOutstandingLimit");

Using ZooKeeper properties as Java system properties causes following
problems

1. Can not create two or more ZooKeeper Server in a single JVM
   with different properties for testing
2. The properties initialization and validation is very much mixed with actual business logic which should not be the case.
   ZOOKEEPER-2139 removed the ZooKeeper client side Java System properties so as part of this jira handling only ZooKeeper server side Java System properties to be removed.

Issue Links

• is related to: ZOOKEEPER-2139 Support multiple ZooKeeper client, with different configurations, in a single JVM