[ZOOKEEPER-2329] Clear javac and javadoc warning from zookeeper

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.5.2
• Assignee: Mohammad Arshad
• Reporter: Mohammad Arshad
• Created: 21/Nov/15 21:41
• Updated: 21/Jul/16 20:18
• Resolved: 21/Nov/15 23:35

Description

Currently ZooKeeper java code has 10 javac and 1 javadoc warning. These should be removed.

javac warnings

[javac] Compiling 228 source files to D:\gitHome\zookeeperTrunk\build\classes
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226: warning: [rawtypes] found raw type: List
    [javac]             List args = new LinkedList();
    [javac]             ^
    [javac]   missing type arguments for generic class List<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface List
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226: warning: [rawtypes] found raw type: LinkedList
    [javac]             List args = new LinkedList();
    [javac]                             ^
    [javac]   missing type arguments for generic class LinkedList<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in class LinkedList
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:233: warning: [unchecked] unchecked call to add(E) as a member of the raw type List
    [javac]                 args.add(value);
    [javac]                         ^
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface List
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:239: warning: [unchecked] unchecked conversion
    [javac]             cmdArgs = args;
    [javac]                       ^
    [javac]   required: List<String>
    [javac]   found:    List
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\jmx\ManagedUtil.java:62: warning: [rawtypes] found raw type: Enumeration
    [javac]         Enumeration enumer = r.getCurrentLoggers();
    [javac]         ^
    [javac]   missing type arguments for generic class Enumeration<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface Enumeration
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\AdminServer.java:33: warning: [serial] serializable class AdminServerException has no definition of serialVersionUID
    [javac]     public class AdminServerException extends Exception {
    [javac]            ^
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\JettyAdminServer.java:142: warning: [serial] serializable class JettyAdminServer.CommandServlet has no definition of serialVersionUID
    [javac]     private class CommandServlet extends HttpServlet {
    [javac]             ^
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:39: warning: [rawtypes] found raw type: Class
    [javac]     getInstanceMethod = classRef.getMethod("getInstance", new Class[0]);
    [javac]                                                               ^
    [javac]   missing type arguments for generic class Class<T>
    [javac]   where T is a type-variable:
    [javac]     T extends Object declared in class Class
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:42: warning: [rawtypes] found raw type: Class
    [javac]          new Class[0]);
    [javac]              ^
    [javac]   missing type arguments for generic class Class<T>
    [javac]   where T is a type-variable:
    [javac]     T extends Object declared in class Class
    [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\OSMXBean.java:89: warning: [rawtypes] found raw type: Class
    [javac]                 new Class[0]);
    [javac]                     ^
    [javac]   missing type arguments for generic class Class<T>
    [javac]   where T is a type-variable:
    [javac]     T extends Object declared in class Class
    [javac] 10 warnings

javadoc warning

[javadoc] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\PurgeTxnLog.java:172: warning - @return tag has no arguments.