[ZOOKEEPER-2316] comment does not match code logic

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.5.1
• Fix Version/s: 3.5.4, 3.6.0
• Component/s: server
• Assignee: Umesh Panchaksharaiah
• Reporter: sunhaitao
• Created: 06/Nov/15 14:34
• Updated: 13/Jul/17 03:07
• Resolved: 27/Apr/17 21:21

Description

when i read the code below, the comment is put in an incorrect,place.
" // in order to be committed, a proposal must be accepted by a quorum "
should be place on top of :
if (!p.hasAllQuorums())

{ return false; }

---------------------------------------------------------------------------------------
3.5.1 Leader code
// getting a quorum from all necessary configurations
if (!p.hasAllQuorums()) { return false; }

// commit proposals in order
if (zxid != lastCommitted+1)

{ LOG.warn("Commiting zxid 0x" + Long.toHexString(zxid) + " from " + followerAddr + " not first!"); LOG.warn("First is " + (lastCommitted+1)); }

// in order to be committed, a proposal must be accepted by a quorum

outstandingProposals.remove(zxid);

Issue Links

• links to: GitHub Pull Request #223