ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-221

log message in ZkWatchManager.materialize missing conditional

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.1, 3.1.0
    • Component/s: java client
    • Labels:
      None

      Description

      the following code is missing conditional log call based on result of remove call (size > 0)

      // XXX This shouldn't be needed, but just in case
      > synchronized (existWatches)

      { > addTo(existWatches.remove(path), result); > LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!"); > }

      >

        Issue Links

          Activity

          Hide
          Patrick Hunt added a comment -

          wrap log message in conditional base on remove result.

          Show
          Patrick Hunt added a comment - wrap log message in conditional base on remove result.
          Hide
          Mahadev konar added a comment -

          Looks like ZOOKEEPER-204 has the fix already.. can you verify?

          Show
          Mahadev konar added a comment - Looks like ZOOKEEPER-204 has the fix already.. can you verify?
          Hide
          Mahadev konar added a comment -

          this is fixed in ZOOKEEPER-204.

          Show
          Mahadev konar added a comment - this is fixed in ZOOKEEPER-204 .

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development