[ZOOKEEPER-2096] C client builds with incorrect error codes in VisualStudio 2010+

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.6, 3.5.0
• Fix Version/s: 3.4.7, 3.5.1, 3.6.0
• Component/s: build, c client

Environment

Windows MSVS 2010+

• Assignee: Vitaly Stakhovsky
• Reporter: Vitaly Stakhovsky
• Created: 19/Dec/14 17:41
• Updated: 03/Mar/16 01:30
• Resolved: 02/Jun/15 20:44

Description

It reports:
warning C4005: 'EWOULDBLOCK' : macro redefinition
warning C4005: 'EINPROGRESS' : macro redefinition

In MSVS 2010+, these constants are now in <errno.h>.
What's worse, they have different numeric values.

Possible fix:
In "src/c/include/winconfig.h" :
#if _MSC_VER < 1600
#define EWOULDBLOCK WSAEWOULDBLOCK
#define EINPROGRESS WSAEINPROGRESS
#endif