Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2096

C client builds with incorrect error codes in VisualStudio 2010+

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.6, 3.5.0
    • Fix Version/s: 3.4.7, 3.5.1, 3.6.0
    • Component/s: build, c client
    • Labels:
      None
    • Environment:

      Windows MSVS 2010+

      Description

      It reports:
      warning C4005: 'EWOULDBLOCK' : macro redefinition
      warning C4005: 'EINPROGRESS' : macro redefinition

      In MSVS 2010+, these constants are now in <errno.h>.
      What's worse, they have different numeric values.

      Possible fix:
      In "src/c/include/winconfig.h" :
      #if _MSC_VER < 1600
      #define EWOULDBLOCK WSAEWOULDBLOCK
      #define EINPROGRESS WSAEINPROGRESS
      #endif

        Attachments

        1. ZOOKEEPER-2096.patch
          0.4 kB
          Vitaly Stakhovsky
        2. ZOOKEEPER-2096.patch
          1 kB
          Vitaly Stakhovsky
        3. ZOOKEEPER-2096.patch
          1 kB
          Vitaly Stakhovsky
        4. ZOOKEEPER-2096.patch
          1 kB
          Vitaly Stakhovsky
        5. ZOOKEEPER-2096.patch
          0.9 kB
          Vitaly Stakhovsky
        6. ZOOKEEPER-2096.patch.branch34
          1 kB
          Vitaly Stakhovsky

          Activity

            People

            • Assignee:
              vvs Vitaly Stakhovsky
              Reporter:
              vvs Vitaly Stakhovsky
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified